Bug 1844643

Summary: Review Request: qwt5-qt5 - Qt Widgets for Technical Applications adapted to Qt5
Product: [Fedora] Fedora Reporter: Alexander Ploumistos <alex.ploumistos>
Component: Package ReviewAssignee: Gergely Gombos <gombosg>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: gombosg, package-review
Target Milestone: ---Flags: gombosg: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-06-26 00:44:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1830463    

Description Alexander Ploumistos 2020-06-05 22:23:32 UTC 
Spec URL: https://alexpl.fedorapeople.org/packages/qwt5-qt5/qwt5-qt5.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/qwt5-qt5/qwt5-qt5-5.2.3a-3.20190819giteeacc44.fc32.src.rpm

COPR: https://copr.fedorainfracloud.org/coprs/alexpl/scidavis/

Scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=45467281
https://koji.fedoraproject.org/koji/taskinfo?taskID=45467298


Description:
The Qwt library contains GUI Components and utility classes which are primarily
useful for programs with a technical background.
Besides a 2D plot widget it provides scales, sliders, dials, compasses,
thermometers, wheels and knobs to control or display values, arrays
or ranges of type double.

While we do have various qwt and qwt5 packages in Fedora, we do not have Qwt5 built with Qt5, which is needed in order to update SciDAVis to version 2.x.

The source of this package is essentially a fork of the last maintenance release of the Qwt 5.x branch:
https://sourceforge.net/projects/qwt/files/qwt/5.2.3/
As far as I know, it's used by other distributions that carry SciDAVis 2.x. The differences from the original are that a few bugs have been fixed and that installation paths in configuration files have been patched to comply with our guidelines (the developer who forked the code is also a Fedora user and he works on SciDAVis upstream).

I have been using this fork since November 2018 and a little after that I added it to my COPR, in order to provide pre-release builds of SciDAVis 2.x.


Fedora Account System Username: alexpl
Comment 1 Gergely Gombos 2020-06-14 15:19:17 UTC 
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Qwt License 1.0 should be "LGPLv2+ with exceptions" according to the 
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
(Bundled COPYING file is LGPLv2.1 with exceptions.)
- Feedback needed: qt5-qtbase looks to be required for this package to function. 
It owns %{_qt5_docdir}. If it is required anyway, then you "should not" own that 
directory. How do you see this?
- You could set "master" to e.g. a "branch" macro, it is used everywhere in the specfile,
and it is not a static value.
- Maybe you could add to the -doc description that it's HTML documentation? Optional.
- Note, I haven't tested the actual software API, only the packaging.

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
     /usr/lib64/qt5/plugins/designer/libqwt5_designer_plugin.so is not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/doc/qt5(qt5-qtbase, qwt-doc), /usr/share/doc/qt5/html(qwt-
     doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: qwt5-qt5-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-devel-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-doc-5.2.3a-3.20190819giteeacc44.fc33.noarch.rpm
          qwt5-qt5-debuginfo-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-debugsource-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-5.2.3a-3.20190819giteeacc44.fc33.src.rpm
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtLinearScaleEngine.qt5.3.gz 38: warning: numeric expression expected (got `f')
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtLog10ScaleEngine.qt5.3.gz 41: warning: numeric expression expected (got `f')
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 478: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 479: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 480: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 481: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtinstall.qt5.3.gz 52: warning: macro `man' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtinstall.qt5.3.gz 108: warning: macro `Programs->Qt' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 157: warning: macro `work' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 466: warning: macro `any' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 517: warning: macro `copyright'' not defined
6 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (debuginfo)
-------------------
Checking: qwt5-qt5-debuginfo-5.2.3a-3.20190819giteeacc44.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-debugsource.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-devel.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-doc.noarch: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-debuginfo.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
5 packages and 0 specfiles checked; 0 errors, 5 warnings.



Unversioned so-files
--------------------
qwt5-qt5: /usr/lib64/qt5/plugins/designer/libqwt5_designer_plugin.so

Source checksums
----------------
https://github.com/gbm19/qwt5-qt5/archive/master/qwt5-qt5-master.tar.gz :
  CHECKSUM(SHA256) this package     : ba9c1e53f04059dfa8dfa35ce22ccede1c2baff26b91700b3b094993079d6108
  CHECKSUM(SHA256) upstream package : ba9c1e53f04059dfa8dfa35ce22ccede1c2baff26b91700b3b094993079d6108


Requires
--------
qwt5-qt5 (rpmlib, GLIBC filtered):
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.14)(64bit)
    libQt5Designer.so.5()(64bit)
    libQt5Designer.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libqwt5-qt5.so.5()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

qwt5-qt5-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libqwt5-qt5.so.5()(64bit)
    pkgconfig(Qt5Gui)
    pkgconfig(Qt5PrintSupport)
    pkgconfig(Qt5Svg)
    pkgconfig(Qt5Widgets)
    qwt5-qt5(x86-64)

qwt5-qt5-doc (rpmlib, GLIBC filtered):

qwt5-qt5-debuginfo (rpmlib, GLIBC filtered):

qwt5-qt5-debugsource (rpmlib, GLIBC filtered):



Provides
--------
qwt5-qt5:
    libqwt5-qt5.so.5()(64bit)
    libqwt5_designer_plugin.so()(64bit)
    qwt5-qt5
    qwt5-qt5(x86-64)

qwt5-qt5-devel:
    pkgconfig(qwt5-qt5)
    qwt5-qt5-devel
    qwt5-qt5-devel(x86-64)

qwt5-qt5-doc:
    qwt5-qt5-doc

qwt5-qt5-debuginfo:
    debuginfo(build-id)
    qwt5-qt5-debuginfo
    qwt5-qt5-debuginfo(x86-64)

qwt5-qt5-debugsource:
    qwt5-qt5-debugsource
    qwt5-qt5-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1844643 -v
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Perl, Python, Ocaml, Haskell, Java, R, fonts, PHP, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 2 Alexander Ploumistos 2020-06-14 16:25:37 UTC 
Thanks for taking this Gergely (or do you prefer Greg?)


(In reply to Gergely Gombos from comment #1)
> - Qwt License 1.0 should be "LGPLv2+ with exceptions" according to the 
> https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
> (Bundled COPYING file is LGPLv2.1 with exceptions.)

I will get it fixed.


> - Feedback needed: qt5-qtbase looks to be required for this package to
> function. 
> It owns %{_qt5_docdir}. If it is required anyway, then you "should not" own
> that 
> directory. How do you see this?

I was confused about this when I was looking at the other versions of qwt he have in Fedora, e.g.
https://src.fedoraproject.org/rpms/qwt/blob/master/f/qwt.spec

Rex Dieter writes in his spec file that he takes ownership of the directory in order to avoid installing other qt or qt-doc dependencies. I don't know what you might have installed on your systems, but looking at mine, it seems that QtX applications dump everything under /usr/share/qtX/ and you end up with files from multiple packages in the same folder.

Personally, I don't mind not owning the directory and adding another dependency. I will try it like that.


> - You could set "master" to e.g. a "branch" macro, it is used everywhere in
> the specfile,
> and it is not a static value.

I couldn't come up with anything descriptive enough for a mcaro name that would save me some characters… The upstream of this fork is not going to publish a versioned release, so until they move to Qwt6, it's always going to be "master", only the commit tags will change - if they commit anything else ever again.


> - Maybe you could add to the -doc description that it's HTML documentation?

Will do.


> [!]: Package consistently uses macros (instead of hard-coded directory
>      names).

Other than "master", have I forgotten something else?


> [!]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 30720 bytes in 2 files.

What's wrong here?
Comment 3 Gergely Gombos 2020-06-14 16:34:39 UTC 
I don't mind if you own or not own %{_qt5_docdir} - qt5-qtbase owns it, and it's required by this package through libQt5Core.so.5, up to you to decide. (It's a 'should' in the guidelines.)
Owning %{_qt5_docdir}/html/ makes sense, since you don't need qwt-doc, and adding it as a requires just for this doesn't sound too good.

The !-s in the list are only for the detailed issues, nothing else.
Sorry, the ! in the "Large documentation" item is a pass.

ps. Both Gergely and Greg are fine. :)
Comment 4 Alexander Ploumistos 2020-06-14 19:03:48 UTC 
I *think* I got it all.

Spec URL: https://alexpl.fedorapeople.org/packages/qwt5-qt5/qwt5-qt5.spec
SRPM URL: https://alexpl.fedorapeople.org/packages/qwt5-qt5/qwt5-qt5-5.2.3a-4.20190819giteeacc44.fc32.src.rpm
Comment 5 Gergely Gombos 2020-06-14 19:47:08 UTC 
LGTM! Drop me an email if you are stuck and need reviewing in the future.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
     /usr/lib64/qt5/plugins/designer/libqwt5_designer_plugin.so is not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/doc/qt5/html(qwt-
     doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: qwt5-qt5-5.2.3a-4.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-devel-5.2.3a-4.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-doc-5.2.3a-4.20190819giteeacc44.fc33.noarch.rpm
          qwt5-qt5-debuginfo-5.2.3a-4.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-debugsource-5.2.3a-4.20190819giteeacc44.fc33.x86_64.rpm
          qwt5-qt5-5.2.3a-4.20190819giteeacc44.fc33.src.rpm
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtLinearScaleEngine.qt5.3.gz 38: warning: numeric expression expected (got `f')
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtLog10ScaleEngine.qt5.3.gz 41: warning: numeric expression expected (got `f')
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 478: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 479: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 480: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/QwtScaleDraw.qt5.3.gz 481: a newline character is not allowed in an escape name
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtinstall.qt5.3.gz 52: warning: macro `man' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtinstall.qt5.3.gz 108: warning: macro `Programs->Qt' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 157: warning: macro `work' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 466: warning: macro `any' not defined
qwt5-qt5-devel.x86_64: W: manual-page-warning /usr/share/man/man3/qwtlicense.qt5.3.gz 517: warning: macro `copyright'' not defined
6 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (debuginfo)
-------------------
Checking: qwt5-qt5-debuginfo-5.2.3a-4.20190819giteeacc44.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-doc.noarch: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-devel.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-debugsource.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
qwt5-qt5-debuginfo.x86_64: W: invalid-url URL: https://github.com/gbm19/qwt5-qt5 <urlopen error [Errno -2] Name or service not known>
5 packages and 0 specfiles checked; 0 errors, 5 warnings.



Unversioned so-files
--------------------
qwt5-qt5: /usr/lib64/qt5/plugins/designer/libqwt5_designer_plugin.so

Source checksums
----------------
https://github.com/gbm19/qwt5-qt5/archive/master/qwt5-qt5-master.tar.gz :
  CHECKSUM(SHA256) this package     : ba9c1e53f04059dfa8dfa35ce22ccede1c2baff26b91700b3b094993079d6108
  CHECKSUM(SHA256) upstream package : ba9c1e53f04059dfa8dfa35ce22ccede1c2baff26b91700b3b094993079d6108


Requires
--------
qwt5-qt5 (rpmlib, GLIBC filtered):
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.14)(64bit)
    libQt5Designer.so.5()(64bit)
    libQt5Designer.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Svg.so.5()(64bit)
    libQt5Svg.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libqwt5-qt5.so.5()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

qwt5-qt5-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libqwt5-qt5.so.5()(64bit)
    pkgconfig(Qt5Gui)
    pkgconfig(Qt5PrintSupport)
    pkgconfig(Qt5Svg)
    pkgconfig(Qt5Widgets)
    qwt5-qt5(x86-64)

qwt5-qt5-doc (rpmlib, GLIBC filtered):
    qt5-qtbase

qwt5-qt5-debuginfo (rpmlib, GLIBC filtered):

qwt5-qt5-debugsource (rpmlib, GLIBC filtered):



Provides
--------
qwt5-qt5:
    libqwt5-qt5.so.5()(64bit)
    libqwt5_designer_plugin.so()(64bit)
    qwt5-qt5
    qwt5-qt5(x86-64)

qwt5-qt5-devel:
    pkgconfig(qwt5-qt5)
    qwt5-qt5-devel
    qwt5-qt5-devel(x86-64)

qwt5-qt5-doc:
    qwt5-qt5-doc

qwt5-qt5-debuginfo:
    debuginfo(build-id)
    qwt5-qt5-debuginfo
    qwt5-qt5-debuginfo(x86-64)

qwt5-qt5-debugsource:
    qwt5-qt5-debugsource
    qwt5-qt5-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1844643 -v
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Java, Perl, Haskell, SugarActivity, PHP, fonts, R, Python, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 6 Alexander Ploumistos 2020-06-14 20:00:58 UTC 
(In reply to Gergely Gombos from comment #5)
> LGTM! Drop me an email if you are stuck and need reviewing in the future.

Thank you very much Gergely, I'll try to be as prompt with your review.
Comment 7 Gwyn Ciesla 2020-06-14 23:38:05 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qwt5-qt5
Comment 8 Fedora Update System 2020-06-15 21:10:30 UTC 
FEDORA-2020-44477df31a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-44477df31a
Comment 9 Fedora Update System 2020-06-15 21:10:44 UTC 
FEDORA-2020-eec8591e24 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-eec8591e24
Comment 10 Fedora Update System 2020-06-16 07:20:27 UTC 
FEDORA-2020-44477df31a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-44477df31a
Comment 11 Fedora Update System 2020-06-16 07:22:12 UTC 
FEDORA-2020-eec8591e24 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-eec8591e24
Comment 12 Fedora Update System 2020-06-18 13:40:39 UTC 
FEDORA-2020-eec8591e24 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-eec8591e24`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-eec8591e24

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 13 Fedora Update System 2020-06-18 14:12:47 UTC 
FEDORA-2020-44477df31a has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-44477df31a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-44477df31a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 14 Fedora Update System 2020-06-26 00:44:59 UTC 
FEDORA-2020-44477df31a has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 15 Fedora Update System 2020-06-26 01:07:13 UTC 
FEDORA-2020-eec8591e24 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.