Bug 1845060

Summary:	Node-labeller is in pending state when node doesn't have kvm device
Product:	Container Native Virtualization (CNV)	Reporter:	Karel Šimon <ksimon>
Component:	SSP	Assignee:	Karel Šimon <ksimon>
Status:	CLOSED ERRATA	QA Contact:	Israel Pinto <ipinto>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.4.0	CC:	cnv-qe-bugs, fdeutsch, ncredi
Target Milestone:	---
Target Release:	2.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	kubevirt-ssp-operator-container-v2.4.0-50	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-28 19:10:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karel Šimon 2020-06-08 11:40:45 UTC

Description of problem:
When node doesn't have a kvm device, node labeller stays in a pending state. 

How reproducible:
100%

Steps to Reproduce:
1. Deploy labeller on the node which doesn't have kvm device

Actual results:
Labeller is in pending state

Expected results:
Labeller runs, or is not scheduled

Comment 1 Karel Šimon 2020-06-08 13:44:50 UTC

This will fix it: https://github.com/MarSik/kubevirt-ssp-operator/pull/181
That PR deletes the node kvm device requirement (devices.kubevirt.io/kvm: "1"). Instead it tries to mount kvm device inside the container. If kvm is not available, container exits with 0 and no labels are added. If kvm is available it continues as usual (gather supported cpu, hyperv features and labels the node)

Comment 3 Israel Pinto 2020-07-13 13:42:22 UTC

Node labeller is not on pending in case of no kvm devices.
Verify with: 

Cluster version is 4.5.0-rc.7
kubevirt: v0.30.3
CNV 2.4

Comment 6 errata-xmlrpc 2020-07-28 19:10:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3194