Bug 1845269

Summary:	Review Request: rubygem-minitest-stub-const - Stub constants for the duration of a block in MiniTest
Product:	[Fedora] Fedora	Reporter:	Pavel Valena <pvalena>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, vondruch
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-10 12:01:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pavel Valena 2020-06-08 19:25:12 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01432339-rubygem-minitest-stub-const/rubygem-minitest-stub-const.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01432339-rubygem-minitest-stub-const/rubygem-minitest-stub-const-0.6-1.fc33.src.rpm

Description: 
Fedora Account System Username: pvalena

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45554358
CORP build: https://copr.fedorainfracloud.org/coprs/pvalena/rubygems/build/1432339/

Required in tests for rubygem-puma-5.0.0.beta1.

Comment 1 Pavel Valena 2020-06-08 19:27:02 UTC

Sorry, I forgot to fill in Description:

Stub constants for the duration of a block in MiniTest.

Comment 2 Vít Ondruch 2020-06-10 12:01:27 UTC

https://src.fedoraproject.org/rpms/rubygem-minitest-stub-const

Comment 3 Pavel Valena 2020-06-10 19:49:42 UTC

Thanks, I must've missed that as the require is inconsistent with the gem name (minitest/stub_const), so I was looking for minitest-stub_const at first...

Comment 4 Vít Ondruch 2020-06-11 07:40:56 UTC

(In reply to Pavel Valena from comment #3)
> I was looking for minitest-stub_const at first...

Maybe something to discuss upstream:

https://guides.rubygems.org/name-your-gem/

But checking the source code of the gem, it seems there is possible [1]:

~~~
require 'minitest/stub/const'
~~~

as well as

~~~
require 'minitest/stub_const'
~~~

So you probably want to change this on consumer side.


[1]: https://github.com/adammck/minitest-stub-const/pull/3

Comment 5 Pavel Valena 2020-06-11 09:45:21 UTC

(In reply to Vít Ondruch from comment #4)
> So you probably want to change this on consumer side.

Sure, I'll look into that. Thanks!