Bug 1845281

Summary:	EmbeddedAnsible UI doesn't allow for file:// git urls
Product:	Red Hat CloudForms Management Engine	Reporter:	Nick LaMuro <nlamuro>
Component:	UI - OPS	Assignee:	Nick LaMuro <nlamuro>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.11.0	CC:	dmetzger, hkataria, mzazrivec, nansari, simaishi, znemecko
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.11.7	Flags:	simaishi: cfme-5.11.z+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.11.7.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-06 14:32:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Nick LaMuro 2020-06-08 19:57:19 UTC

Description of problem:

As part of https://bugzilla.redhat.com/show_bug.cgi?id=1465966 there was a feature request to have local file:// urls work for git repos.  At the time, EmbeddedAnsible was dependent on AWX, so this was a feature that was somewhat dependent on that.

After the release of 5.11, using local git repository support was added to the model validation as part of this change:

https://github.com/ManageIQ/manageiq/pull/19013/

But that change never found it reflected in the model.  There were work arounds to enter via the console with this ticket:

https://bugzilla.redhat.com/show_bug.cgi?id=1738588

But that didn't fix the UI which owns it's own repo



Version-Release number of selected component (if applicable):  5.11


How reproducible:  Always


Steps to Reproduce:

1.  Enable EmbeddedAnsible
2.  Go to Automation -> Ansible -> Repositories and add a new repo
3.  Try entering something like `file:///var/www/...`


Actual results:

This will cause a validation error that prevents the user from saving the record, even though the backend will allow a URL like this


Expected results:

No validation error


Additional info:


Related BZs:

- https://bugzilla.redhat.com/show_bug.cgi?id=1738588
- https://bugzilla.redhat.com/show_bug.cgi?id=1465966


This might have been a problem prior to 5.11, but I think it makes sense to only support it in 5.11 going forward (if not just 5.12), and leave the previous functionality in place (unless a user specifically requests it).

Comment 2 Nick LaMuro 2020-06-08 19:58:07 UTC

Fixed already via https://github.com/ManageIQ/manageiq-ui-classic/pull/7105

Comment 3 Dave Johnson 2020-06-08 20:03:34 UTC

Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 4 CFME Bot 2020-07-01 17:15:51 UTC

New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/2c4ff7ddf8c4a95088f48c6c457fc4eeb1bb7ed8
commit 2c4ff7ddf8c4a95088f48c6c457fc4eeb1bb7ed8
Author:     Martin Hradil <mhradil>
AuthorDate: Tue Jun  9 12:33:37 2020 +0000
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Jul  1 17:13:54 2020 +0000

    Merge pull request #7105 from NickLaMuro/allow-file-urls-for-frontend-scm-url-validation

    [url_validation.js] Allow for file:// urls

    (cherry picked from commit 98fcecb680a5908af91df54acb80fb7b8670635e)

    https://bugzilla.redhat.com/show_bug.cgi?id=1845281

 app/assets/javascripts/directives/url_validation.js | 4 +-
 app/views/ansible_repository/_repository_form.html.haml | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comment 5 Gaurav Talreja 2020-07-17 07:10:35 UTC

Verified in Version : 5.11.7.0.20200714215453_0da8a4a

Comment 8 errata-xmlrpc 2020-08-06 14:32:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Critical: CloudForms 5.0.7 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3358