Bug 1846376

Summary: rebase accountsservice to latest release
Product: Red Hat Enterprise Linux 8 Reporter: Vladimir Benes <vbenes>
Component: accountsserviceAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED ERRATA QA Contact: Michal Odehnal <modehnal>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: bsanford, jadahl, jkoten, tpelka
Target Milestone: rcKeywords: Rebase, Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
URL: https://faf.lab.eng.brq.redhat.com/faf/reports/bthash/189ab3d992bd9b1f14204626844a218ab0d50f33/
Whiteboard:
Fixed In Version: accountsservice-0.6.55-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-05-18 14:38:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladimir Benes 2020-06-11 13:12:21 UTC
There is a crash in GS.. even the newest gnome-shell-3.32.2-16.el8.x86_64

Report URL: https://faf.lab.eng.brq.redhat.com/faf/reports/bthash/189ab3d992bd9b1f14204626844a218ab0d50f33/

any idea?

backtrace (and coredump) is in FAF report in linked in the report.

Comment 1 Florian Müllner 2020-06-23 13:51:50 UTC
The backtrace is missing symbols for accountsservice-libs, but I think this is where the crash is happening:

  static void
  update_user (ActUserManager *manager,
               ActUser        *user)
  {
          ActUserManagerPrivate *priv = act_user_manager_get_instance_private (manager);
          const char *username;

          g_debug ("ActUserManager: updating %s", describe_user (user));

          username = act_user_get_user_name (user);
          if (g_hash_table_lookup (priv->system_users_by_name, username) != NULL) {
                  [...]
          }
  }

g_hash_table_lookup() is called with a key of NULL, so that's what act_user_get_user_name() returns.

It's unclear why that would happen though: That function should only return NULL when user->accounts_proxy isn't set, but given that update_user() itself is only called when any of the proxy properties changed, that's not supposed to happen.

In any case this doesn't look like something triggered by gnome-shell, so moving to accounts-service.

Comment 2 Ray Strode [halfline] 2020-06-23 18:13:46 UTC
my guess is, accountsservice is going away, leaving the proxy dangling.

If so, this crash might be fixed by this:

    https://gitlab.freedesktop.org/accountsservice/accountsservice/issues/55

But why would accountsservice be going away? Is it crashing?  

Looking in the log I see this:

Jun 10 12:06:32 beaker-network-manager-applet-develop-265 systemd[1]: Stopping Accounts Service...
Jun 10 12:06:32 beaker-network-manager-applet-develop-265 systemd[1]: Stopped Accounts Service.
Jun 10 12:06:32 beaker-network-manager-applet-develop-265 systemd[1]: Starting Accounts Service...
Jun 10 12:06:32 beaker-network-manager-applet-develop-265 accounts-daemon[64565]: started daemon version 0.6.50
Jun 10 12:06:32 beaker-network-manager-applet-develop-265 kernel: gdm-session-wor[62685]: segfault at 0 ip 00007f8feb4159e4 sp 00007ffc3ddce528 error 4 in libglib-2.0.so.0.5600.4[7f8feb3d9000+116000]

so it looks like accountsservice is getting explicitly restarted? Indeed, there's a crash by a user of libaccountsservice immediately after the restart, too...

I haven't tried to reproduce yet, but I bet "systemctl restart accountsservice" enough times will trigger it. if so, it should be straight forward to test the upstream fix above.

Comment 10 Michal Odehnal 2021-01-19 15:55:25 UTC
Tests run for accountsservice, gdm and gnome-control-center all passed with no issues, switching to Verified: Tested

Comment 15 errata-xmlrpc 2021-05-18 14:38:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: GNOME security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1586