Bug 1847073

Summary: Login page footer should be a footer below the login pane
Product: Red Hat Satellite Reporter: Will D <will_darton>
Component: SettingsAssignee: Ron Lavi <rlavi>
Status: CLOSED ERRATA QA Contact: Devendra Singh <desingh>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.9.0CC: ahumbe, apatel, kagarwal, mhulan, rlavi, zhunting
Target Milestone: 6.9.0Keywords: EasyFix, Triaged, UserExperience
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: foreman-2.3.1.10-1,foreman-2.3.1.11-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-21 13:14:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Login Banner
none
Suggested refactor in Foreman none

Description Will D 2020-06-15 15:15:25 UTC
Created attachment 1697467 [details]
Login Banner

Description of problem:
The Administrator > Settings > Login Page footer text appears above the Login Pane on the main Login Page for Satellite. When a long banner is used, such as a standard government banner, it moves the login pane well down the screen.  Since it's called a footer, it should be below the Login Pane

Version-Release number of selected component (if applicable):
6.7.0

How reproducible:
Reproducible on every login

Steps to Reproduce:
1. Create a long custom footer under Administrator > Settings > Login Page footer text
2. Logout
3. Note the banner is above the Login Pane

Actual results:
Login Pane is below the Login footer text

Expected results:
The 'footer' should be below the Login Pane

Additional info:
Screen capture attached

Comment 3 Ron Lavi 2020-08-19 11:19:13 UTC
Hi, the footer setting is derived from the old page where that text was shown on the bottom-right corner of the page,

In PF3 design: https://www.patternfly.org/v3/pattern-library/application-framework/login-page/#design

there is no section for that footer text, but I think we could add something in Foreman or open a PR to PF3.

On a UX perspective it feels the text is too big, maybe it could be change into collapsible section or a popup with approve button

Comment 10 Ron Lavi 2021-02-11 11:11:15 UTC
Hi, I added a small refactor for it in https://projects.theforeman.org/issues/31857 & https://projects.theforeman.org/issues/31857
let me know if that works for you, I will also discuss it with UXD

Comment 11 Bryan Kearney 2021-02-11 12:02:36 UTC
Upstream bug assigned to rlavi

Comment 12 Bryan Kearney 2021-02-11 12:02:39 UTC
Upstream bug assigned to rlavi

Comment 13 Ron Lavi 2021-02-11 14:16:35 UTC
Created attachment 1756375 [details]
Suggested refactor in Foreman

Comment 14 Ron Lavi 2021-02-14 09:25:41 UTC
While I am not sure when the upstream PR will be merged,
I Added GitLab CHERRY-PICK PR: https://gitlab.sat.engineering.redhat.com/satellite6/foreman/-/merge_requests/566

Comment 18 Devendra Singh 2021-02-25 15:13:08 UTC
Verified on 6.9 Snap 15.

Verification points

1: Create a long custom footer under Administrator > Settings > Login Page footer text
2: Logout
3: All the text is displayed below the Login Pane.
4: Verified the fixed package.

# rpm -qa|grep ^foreman-2.3.1.
foreman-2.3.1.11-1.el7sat.noarch

Comment 22 errata-xmlrpc 2021-04-21 13:14:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.9 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1313