Bug 1847889

Summary:	VerifyDhcpConfigSyntax check should not run if external DHCP
Product:	Red Hat Satellite	Reporter:	Suraj Patil <supatil>
Component:	Satellite Maintain	Assignee:	Suraj Patil <supatil>
Status:	CLOSED ERRATA	QA Contact:	Gaurav Talreja <gtalreja>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.7.0	CC:	apatel, egolov, gtalreja, kgaikwad
Target Milestone:	6.9.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-foreman_maintain-0.6.9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-21 14:48:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Suraj Patil 2020-06-17 09:49:41 UTC

Description of problem:
Check for verifying syntax for ISP DHCP configurations should not be run if the satellite is configured with external DHCP such as Infoblox. 

Version-Release number of selected component (if applicable):
satellite 6.7

How reproducible:
 1) Configure satellite with external DHCP
 2) Run foreman-maintain health check

Comment 1 Suraj Patil 2020-06-17 09:51:08 UTC

Created redmine issue https://projects.theforeman.org/issues/30140 from this bug

Comment 2 Bryan Kearney 2020-07-29 12:04:59 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/30140 has been resolved.

Comment 3 Gaurav Talreja 2020-12-30 10:25:22 UTC

Verified.

Tested on Satellite 6.9.0 Snap 7.0 
Version: rubygem-foreman_maintain-0.7.0-1.el7sat.noarch

Setup:
1. Satellite instance configured with external DHCP like Infoblox, which has `:use_provider: dhcp_infoblox` set in /etc/foreman-proxy/settings.d/dhcp.yml
2. Satellite instance which is DHCP enabled and has `:use_provider: dhcp_isc` set in /etc/foreman-proxy/settings.d/dhcp.yml

Steps:
On Satellite integrated with Infoblox,
1. # foreman-maintain health list | grep foreman-proxy-verify-dhcp-config-syntax   // No output as no check exists
2. # foreman-maintain health check --label foreman-proxy-verify-dhcp-config-syntax
No scenario matching label [foreman-proxy-verify-dhcp-config-syntax]
3. # echo $?
1

On Satellite with dhcp_isc,
1. # foreman-maintain health list | grep foreman-proxy-verify-dhcp-config-syntax
[foreman-proxy-verify-dhcp-config-syntax] Check for verifying syntax for ISP DHCP configurations [default]
2. # foreman-maintain health check --label foreman-proxy-verify-dhcp-config-syntax
Running ForemanMaintain::Scenario::FilteredScenario
================================================================================
Check for verifying syntax for ISP DHCP configurations:               [OK]
--------------------------------------------------------------------------------
3. # echo $?
0

Observation: 
Check is not available on the satellite instances where `:use_provider:` is set other than `dhcp_isc`, and also not on DHCP disabled Satellite

Comment 6 errata-xmlrpc 2021-04-21 14:48:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.9 Satellite Maintenance Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:1312