Bug 1848027

Summary:	Review Request: perl-SQL-Abstract-Classic - Generate SQL from Perl data structures
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-SQL-Abstract-Classic-1.91-1.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-18 09:00:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1847730

Description Jitka Plesnikova 2020-06-17 14:40:07 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-SQL-Abstract-Classic/perl-SQL-Abstract-Classic.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-SQL-Abstract-Classic/perl-SQL-Abstract-Classic-1.91-1.fc33.src.rpm

Description:
This module was inspired by the excellent DBIx::Abstract. However, in using
that module I found that what I really wanted to do was generate SQL, but
still retain complete control over my statement handles and use the DBI
interface. So, I set out to create an abstract SQL generation module.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2020-06-17 15:23:27 UTC

The Url and Source0 addresses are Ok.
A Source0 archive (SHA-256: 4e3d1dfd095b2123268586bb06b86929ea571388d4e941acccbdcda1e108ef28) is original. Ok.
Summary verified from lib/SQL/Abstract/Classic.pm. Ok.
Description verified from lib/SQL/Abstract/Classic.pm. Ok.
License verified from lib/SQL/Abstract/Classic.pm and Makefile.PL. Ok.
No XS code, noarch BuildArch is Ok.

Test::Deep is not used. Ok.
MRO::Compat is not used with recent perl. Ok.

All tests pass. Ok.

$ rpmlint perl-SQL-Abstract-Classic.spec ../SRPMS/perl-SQL-Abstract-Classic-1.91-1.fc33.src.rpm ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Jun 17 17:17 /usr/share/doc/perl-SQL-Abstract-Classic
-rw-r--r--    1 root     root                    16163 Oct 17  2019 /usr/share/doc/perl-SQL-Abstract-Classic/Changes
-rw-r--r--    1 root     root                    17109 Jun 17 17:16 /usr/share/man/man3/SQL::Abstract::Classic.3pm.gz
-rw-r--r--    1 root     root                     2284 Jun 17 17:16 /usr/share/man/man3/SQL::Abstract::Util.3pm.gz
drwxr-xr-x    2 root     root                        0 Jun 17 17:16 /usr/share/perl5/vendor_perl/SQL
drwxr-xr-x    2 root     root                        0 Jun 17 17:16 /usr/share/perl5/vendor_perl/SQL/Abstract
-rw-r--r--    1 root     root                    89689 Oct 17  2019 /usr/share/perl5/vendor_perl/SQL/Abstract/Classic.pm
-rw-r--r--    1 root     root                     4985 Oct 17  2019 /usr/share/perl5/vendor_perl/SQL/Abstract/Util.pm
The file permissions and a layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.3)
      1 perl(Carp)
      1 perl(Exporter) >= 5.57
      1 perl(List::Util)
      1 perl(mro)
      1 perl(Scalar::Util)
      1 perl(SQL::Abstract) >= 1.79
      1 perl(SQL::Abstract::Util)
      1 perl(strict)
      1 perl(Text::Balanced) >= 2.00
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Drop a run-time dependency on SQL::Abstract. It's not used anywhere. Probably a remnant of forking from SQL::Abstract. I can see that it's there because of a version of SQL::Abstract::Test. But SQL::Abstract::Test is used only when the tests are performed.

$ rpm -q --provides -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(SQL::Abstract::Classic) = 1.91
      1 perl(SQL::Abstract::Util)
      1 perl-SQL-Abstract-Classic = 1.91-1.fc33
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm 
Binary dependencies are resolvable. Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the 'FIX' item before building the package.
Resolution: Package APPROVED.

The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=45828264). OK.

Comment 2 Igor Raits 2020-06-18 07:01:32 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-SQL-Abstract-Classic

Comment 3 Jitka Plesnikova 2020-06-18 09:00:41 UTC

Thank you for the review and the repository.