Bug 1848058

Summary: Workspace switcher menu is broken
Product: Red Hat Enterprise Linux 7 Reporter: Michael Catanzaro <mcatanza>
Component: gnome-shellAssignee: Florian Müllner <fmuellner>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: high Docs Contact:
Priority: high    
Version: 7.9CC: desktop-qa-list, fmuellner, jadahl, jkoten, jshortt, jwright, mboisver, modehnal, pvlasin, swachira, tpelka, tpopela
Target Milestone: rcKeywords: ZStream
Target Release: 7.9   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-shell-extensions-3.28.1-14.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1858717 (view as bug list) Environment:
Last Closed: 2020-09-29 20:22:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1858717    
Attachments:
Description Flags
Screenshot
none
workspace screenshot
none
workspace screenshot shell
none
workspace screenshot classic none

Description Michael Catanzaro 2020-06-17 15:10:49 UTC
Created attachment 1697835 [details]
Screenshot

Description of problem: The first time I click the workspace indicator in the bottom-left corner of the screen, it opens the workspace switcher popover mispositioned in the top-left corner of the screen. If I dismiss the menu by clicking on the workspace switcher again, then the workspace switcher no longer does anything: it is no longer possible to reopen the menu.


Version-Release number of selected component (if applicable): gnome-shell-3.28.3-24.el7


How reproducible: Always


Steps to Reproduce:
1. Log into GNOME
2. Click the workspace indicator. Menu appears mispositioned.
3. Click it again. Menu disappears.
4. Click it again. Nothing happens.

Actual results: The workspace indicator no longer does anything, all clicks are ignored until I sign out.


Expected results: The workspace menu appears in the correct location.


Additional info: Screenshot attached

Comment 2 Michael Catanzaro 2020-06-17 15:16:00 UTC
Florian thinks he has fixed it. He says it's caused by this error in my journal:

Jun 17 10:09:00 rhel7 gnome-shell[2782]: JS ERROR: TypeError: sourceActor.get_theme_node is not a function
                                         _reposition@resource:///org/gnome/shell/ui/boxpointer.js:451:26
                                         wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                         setPosition@resource:///org/gnome/shell/ui/boxpointer.js:433:9
                                         wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                         open@resource:///org/gnome/shell/ui/popupMenu.js:866:9
                                         wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                         toggle@resource:///org/gnome/shell/ui/popupMenu.js:746:13
                                         wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                         _onEvent@resource:///org/gnome/shell/ui/panelMenu.js:138:13
                                         wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22

Comment 7 Michael Boisvert 2020-06-18 16:29:05 UTC
Created attachment 1697989 [details]
workspace screenshot

With the updated mutter from [1] the workspace indicator extension is broken in a different way. Now there are two horizontal workspace switchers, but no indicators.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1848103

Comment 8 Michael Catanzaro 2020-06-18 17:52:56 UTC
*** Bug 1848626 has been marked as a duplicate of this bug. ***

Comment 14 Florian Müllner 2020-06-19 19:52:27 UTC
(In reply to Michael Boisvert from comment #7)
> Created attachment 1697989 [details]
> workspace screenshot
> 
> With the updated mutter from [1] the workspace indicator extension is broken
> in a different way. Now there are two horizontal workspace switchers, but no
> indicators.

There are two implementations of the workspace switcher (both the menu for vertical layouts and the thumbnail switcher for horizontal layouts):

 - the stand-alone workspace-indicator extension (shipped in gnome-shell-extensions, but not included in GNOME Classic by default)

 - a fork of that extensions that is included in the window-list extension (which is enabled by GNOME Classic)

It simply looks like you have both extensions enabled.

Comment 16 Michael Boisvert 2020-06-21 13:40:00 UTC
Created attachment 1698228 [details]
workspace screenshot shell

The scratch build seems to work properly on gnome-shell, but in classic I figured the functionality would be the same: vertical drop down menu with labeled workspaces. This is not the case, classic still only gets a horizontal workspace selector without labels in the top bar, identical to the default one at the bottom. 

Is this the desired functionality? IIRC classic mode would previously get a similar vertical drop down menu with labeled workspaces when the workspace-indicator extension was enabled. 

See both screenshots.

Comment 17 Michael Boisvert 2020-06-21 13:40:41 UTC
Created attachment 1698229 [details]
workspace screenshot classic

Comment 19 Florian Müllner 2020-06-22 16:24:25 UTC
(In reply to Michael Boisvert from comment #16)

> Is this the desired functionality?

Yes. Both switchers have been updated to either show a menu (as before) or a row of thumbnails. Which one is shown depends on the orientation of the workspace layout, not the extension that is used.

Comment 20 Michael Boisvert 2020-06-22 16:27:24 UTC
(In reply to Florian Müllner from comment #19)
> (In reply to Michael Boisvert from comment #16)
> 
> > Is this the desired functionality?
> 
> Yes. Both switchers have been updated to either show a menu (as before) or a
> row of thumbnails. Which one is shown depends on the orientation of the
> workspace layout, not the extension that is used.

Being that's the case and we could get exception+ by EOD today, this could make it into 7.9.

Comment 24 Michael Boisvert 2020-06-23 13:14:33 UTC
Testing of gnome-shell-extensions-3.28.1-14.el7 yielded expected results on both gnome-shell and shell-classic.

Comment 28 errata-xmlrpc 2020-09-29 20:22:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (GNOME bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3987