Bug 1848718
Summary: | NFS ISO installs fail since anaconda-33.18-1.fc33 if ISO name is included in repo definition | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> | |
Component: | anaconda | Assignee: | Jiri Konecny <jkonecny> | |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | high | Docs Contact: | ||
Priority: | unspecified | |||
Version: | rawhide | CC: | anaconda-maint-list, jkonecny, jonathan, kellin, robatino, vanmeeuwen+fedora, vponcova, wwoods | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | openqa | |||
Fixed In Version: | anaconda-33.20-1 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1849083 (view as bug list) | Environment: | ||
Last Closed: | 2020-07-03 23:35:38 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1766777 |
Description
Adam Williamson
2020-06-18 20:01:52 UTC
So it looks to me like jknoecny completely rewrote this code, initially left out ISO support entirely, then added it back in in https://github.com/rhinstaller/anaconda/commit/af627cd8f68406896b4684ac5b634208d1365f40 but didn't handle this specific path - that code doesn't seem to have any way of accounting for the possibility of the ISO name being specified in the argument. So I think that needs to be added back. If he has time for this I'll leave this to Jiri as I guess he knows how the new code works so he knows where it would make sense to do the parsing for this :) Interesting, I thought I've added this possibility in. I'll try to fix this soon. Thanks a lot for investigating. Sorry for this. I've thought I've taken this into account and I did but not completely and somehow forget to test this or create tests. Now tests are there too. About the rewrote. We did rewrite / moved whole logic how we are working with sources. Before everything touched everything, so it was hard to change something without changing the behavior of completely different source. Right now each source has it's own directories and classes, so it is nicely separated and easier to maintain and enhance. Confirmed fixed in recent composes. |