Bug 1848763

Summary:	metrics role should handle platform dependencies, optional packages better
Product:	Red Hat Enterprise Linux 8	Reporter:	Rich Megginson <rmeggins>
Component:	rhel-system-roles	Assignee:	Rich Megginson <rmeggins>
Status:	CLOSED ERRATA	QA Contact:	Jan Kurik <jkurik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.3	CC:	agerstmayr, djez, nathans, pcahyna
Target Milestone:	rc	Keywords:	Bugfix, Rebase, Triaged
Target Release:	8.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	role:metrics
Fixed In Version:	rhel-system-roles-1.0-16.el8	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 04:03:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rich Megginson 2020-06-18 22:09:35 UTC

Description of problem:

Need better documentation for grafana integration
Need improvements in specifying plaform/version dependencies with packages

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
https://github.com/linux-system-roles/metrics/issues/11

Comment 1 Nathan Scott 2020-07-02 05:38:22 UTC

This is implemented upstream based on Rich's advice in the related github issue...

commit 8fd486ef43704b808c2f2377b23444296abab957
Author: Nathan Scott <nathans>
Date:   Thu Jul 2 15:31:52 2020 +1000

    Provide separate package setups for different platforms/versions
    
    Resolves https://github.com/linux-system-roles/metrics/issues/11

Comment 2 Nathan Scott 2020-07-08 05:41:50 UTC

Discussing with Rich, there's still time to get this bug fix into 8.3.

Comment 5 Jan Kurik 2020-08-17 15:43:41 UTC

Verified by code review.
Optional packages are now handled in separate files, depending on the distro. At this moment there are the following distros supported:

* CentOS-6.yml
* CentOS-7.yml
* CentOS-8.yml
* Fedora.yml
* RedHat-6.yml
* RedHat-7.yml
* RedHat-8.yml

Comment 8 errata-xmlrpc 2020-11-04 04:03:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4809