Bug 1849105

Summary: Default storageclasses, ocs node labels and ocs node taints are not removed when StorageCluster is deleted
Product: [Red Hat Storage] Red Hat OpenShift Container Storage Reporter: Raghavendra Talur <rtalur>
Component: ocs-operatorAssignee: Raghavendra Talur <rtalur>
Status: CLOSED ERRATA QA Contact: Neha Berry <nberry>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.5CC: jarrpa, madam, nberry, ocs-bugs, rojoseph, sostapov
Target Milestone: ---   
Target Release: OCS 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.5.0-518.ci Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-15 10:17:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1760426    

Description Raghavendra Talur 2020-06-19 15:54:29 UTC
Description of problem (please be detailed as possible and provide log
snippests):
When a StorageCluster is deleted, the following items are not removed automatically:
1. StorageClass
2. OCS node labels
3. OCS node taints

Version of all relevant components (if applicable):
4.5

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
Creating a StorageCluster right after deleting is not possible. Requires manual intervention to clean up the remaining items.


Is there any workaround available to the best of your knowledge?
Yes, manually deleted the above listed resources.

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
Yes

Can this issue reproduce from the UI?
Yes

If this is a regression, please provide more details to justify this:
Not a regression

Steps to Reproduce:
1. Create a StorageCluster
2. Deleted the StorageCluster


Actual results:
StorageClasses, Node labels, Node taints aren't removed.

Expected results:
The above listed resources should be removed.

Additional info:

Comment 2 Michael Adam 2020-06-25 09:04:21 UTC
This is manily a BZ describing some aspects of the uninstall epic https://issues.redhat.com/browse/KNIP-1230

Comment 3 Michael Adam 2020-06-25 09:36:06 UTC
providing missing acks after confirming with Raz.

Comment 4 Michael Adam 2020-07-06 09:17:50 UTC
This was done a while ago via:

https://github.com/openshift/ocs-operator/pull/556 - storage classes (before FF)

https://github.com/openshift/ocs-operator/pull/576 - labels (backport)

https://github.com/openshift/ocs-operator/pull/577 - taints (backport)

Comment 8 Michael Adam 2020-07-28 14:52:24 UTC
We should not remove the rack labels since we may or may not have set them.
Just like we don't remove the zone lables.

Comment 9 Jose A. Rivera 2020-08-03 16:57:15 UTC
Michael is correct, the rack labels should not be removed. Moving this back to ON_QA.

Comment 13 Rohan CJ 2020-08-17 05:46:32 UTC
I think that: since the reason we can't remove the rack labels automatically is to
accommodate people who have diverged from the documented install by manually applying the rack labels,
we can keep the manual step to remove them in the documentation.

Handling that case shouldn't be in the scope of the uninstall documentation until the corresponding install process
gets into the install documentation (it might not).

Comment 14 Neha Berry 2020-08-18 17:53:06 UTC
Based on Comment #6 and recent uninstall tests on OCS 4.5.0-521 and 4.5.0-526(rc1) builds, following things are removed in case the storagecluster is deleted:

1. If patched with labelled with  cleanup.ocs.openshift.io=yes-really-destroy-data

a) The /var/lib/rook directory is cleaned up
b) the disk is cleaned up (wipefs)'
c) the dataMonDirHostPath is removed

Along with this, following entities are removed:

d) the OCS storageclasses

ocs-storagecluster-ceph-rbd   openshift-storage.rbd.csi.ceph.com      Delete          Immediate           true                   5d8h
ocs-storagecluster-ceph-rgw   openshift-storage.ceph.rook.io/bucket   Delete          Immediate           false                  5d8h
ocs-storagecluster-cephfs     openshift-storage.cephfs.csi.ceph.com   Delete          Immediate           true                   5d8h


Hence, moving the BZ to verified state.

Comment 16 errata-xmlrpc 2020-09-15 10:17:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Container Storage 4.5.0 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3754

Comment 17 Red Hat Bugzilla 2023-09-14 06:02:26 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days