Bug 1849303 (golang-storj-common)

Summary:	Review Request: golang-storj-common - Storj common packages
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <eclipseo>
Component:	Package Review	Assignee:	Fabian Affolter <mail>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mail, package-review
Target Milestone:	---	Flags:	mail: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-08 20:25:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1849291, 1849293, 1849295, 1849296, 1849300, 1849302
Bug Blocks:	1849305

Description Robert-André Mauchin 🐧 2020-06-20 13:32:20 UTC

Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-storj-common.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-storj-common-0-0.1.20200620git79b46de.fc33.src.rpm

Description:
 Storj common packages.

Fedora Account System Username: eclipseo

Comment 1 Robert-André Mauchin 🐧 2020-06-20 13:45:55 UTC

New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-storj-common.spec
New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-storj-common-0-0.1.20200620git79b46de.fc33.src.rpm

Comment 2 Fabian Affolter 2020-07-16 13:20:25 UTC

At least two tests are failing:

ok  	storj.io/common/pkcrypto	0.468s
storj.io/common/ranger
PASS
ok  	storj.io/common/ranger	0.017s
storj.io/common/ranger/httpranger
2020/07/16 15:17:12 http: superfluous response.WriteHeader call from storj.io/common/ranger/httpranger.TestHTTPRangeStatusCodeOk.func1 (http_test.go:81)
PASS
ok  	storj.io/common/ranger/httpranger	0.014s
storj.io/common/rpc
--- FAIL: TestLookupNodeAddress_Host (0.00s)
    lookup_test.go:22: 
        	Error Trace:	lookup_test.go:22
        	Error:      	Expected value not to be nil.
        	Test:       	TestLookupNodeAddress_Host
--- FAIL: TestLookupNodeAddress_HostAndPort (0.00s)
    lookup_test.go:33: 
        	Error Trace:	lookup_test.go:33
        	Error:      	Expected value not to be nil.
        	Test:       	TestLookupNodeAddress_HostAndPort
FAIL
exit status 1
FAIL	storj.io/common/rpc	0.009s
error: Bad exit status from /var/tmp/rpm-tmp.a7J3uu (%check)
    Bad exit status from /var/tmp/rpm-tmp.a7J3uu (%check)
RPM build errors:
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace

How about adding a condition for network-related tests?