Bug 1849570

Summary:	[RFE] libvirt: add WRITE SAME/UNMAP block size definition
Product:	Red Hat Enterprise Linux 9	Reporter:	Lukas Herbolt <lherbolt>
Component:	libvirt	Assignee:	khanicov
libvirt sub component:	General	QA Contact:	Meina Li <meili>
Status:	CLOSED MIGRATED	Docs Contact:
Severity:	medium
Priority:	medium	CC:	gveitmic, hhan, jsuchane, jtomko, khanicov, kwolf, lmen, mmuench, mprivozn, pkrempa, vgoyal, virt-maint, yalzhang
Version:	unspecified	Keywords:	FutureFeature, MigratedToJIRA, Reopened, Triaged
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:	storage, virsh cmd
Last Closed:	2023-09-22 17:50:48 UTC	Type:	Story
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lukas Herbolt 2020-06-22 09:21:08 UTC

Description of problem: Currently the QEMU process is able to set WRITE_SAME/UNMAP granularity. This option is not available in libvirt
and workaround needs to be used to set it up. 

Current workaround is to set additional commands while starting qemu:

<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
        <qemu:commandline>
                <qemu:arg value='-set'/>
                <qemu:arg value='block.scsi0-0-0.discard_granularity=4194304'/>
        </qemu:commandline>
</domain>


Version-Release number of selected component (if applicable):
libvirt-6.0.0-17.2.module+el8.2.0+6629+3fc0f2c2.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. try to define discard granularity option in libvirt 
 
Actual results:
No such option is available. 

Expected results:
Option is available in the libvirt xml when defining storage backend.

Additional info:

Comment 6 John Ferlan 2021-09-14 19:29:59 UTC

Bulk update: Move RHEL8 bugs to RHEL9. If necessary to resolve in RHEL8, then clone to the current RHEL8 release.

Comment 8 RHEL Program Management 2021-12-22 07:27:03 UTC

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 9 Meina Li 2021-12-24 02:31:42 UTC

Hi khanicov,

Do we still have plan to implement this new feature? If yes, we need to reopen this bug. Thanks.

Comment 10 Michal Privoznik 2022-01-03 13:34:36 UTC

I believe this is still worth implementing. Let me reopen.

Comment 17 Peter Krempa 2023-03-01 14:12:41 UTC

*** Bug 2154127 has been marked as a duplicate of this bug. ***

Comment 18 khanicov 2023-08-25 13:24:12 UTC

merged upstream as:

18705b03c6 qemu: add support for discard_granularity
96d8ee2cff conf: add support for discard_granularity

v9.6.0-173-g18705b03c6

Comment 20 RHEL Program Management 2023-09-22 17:50:27 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 21 RHEL Program Management 2023-09-22 17:50:48 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.