Bug 1849570

Summary:	[RFE] libvirt: add WRITE SAME/UNMAP block size definition
Product:	Red Hat Enterprise Linux 9	Reporter:	Lukas Herbolt <lherbolt>
Component:	libvirt	Assignee:	khanicov
libvirt sub component:	Storage	QA Contact:	Meina Li <meili>
Status:	NEW ---	Docs Contact:
Severity:	medium
Priority:	medium	CC:	gveitmic, jsuchane, jtomko, khanicov, kwolf, lmen, mmuench, mprivozn, pkrempa, vgoyal, virt-maint, yalzhang
Version:	unspecified	Keywords:	FutureFeature, Reopened, Triaged
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:	storage, virsh cmd
Last Closed:	2021-12-22 07:27:03 UTC	Type:	Feature Request
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lukas Herbolt 2020-06-22 09:21:08 UTC

Description of problem: Currently the QEMU process is able to set WRITE_SAME/UNMAP granularity. This option is not available in libvirt
and workaround needs to be used to set it up. 

Current workaround is to set additional commands while starting qemu:

<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'>
        <qemu:commandline>
                <qemu:arg value='-set'/>
                <qemu:arg value='block.scsi0-0-0.discard_granularity=4194304'/>
        </qemu:commandline>
</domain>


Version-Release number of selected component (if applicable):
libvirt-6.0.0-17.2.module+el8.2.0+6629+3fc0f2c2.x86_64

How reproducible:
Every time

Steps to Reproduce:
1. try to define discard granularity option in libvirt 
 
Actual results:
No such option is available. 

Expected results:
Option is available in the libvirt xml when defining storage backend.

Additional info:

Comment 6 John Ferlan 2021-09-14 19:29:59 UTC

Bulk update: Move RHEL8 bugs to RHEL9. If necessary to resolve in RHEL8, then clone to the current RHEL8 release.

Comment 8 RHEL Program Management 2021-12-22 07:27:03 UTC

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 9 Meina Li 2021-12-24 02:31:42 UTC

Hi khanicov,

Do we still have plan to implement this new feature? If yes, we need to reopen this bug. Thanks.

Comment 10 Michal Privoznik 2022-01-03 13:34:36 UTC

I believe this is still worth implementing. Let me reopen.

Comment 17 Peter Krempa 2023-03-01 14:12:41 UTC

*** Bug 2154127 has been marked as a duplicate of this bug. ***