Bug 1849690

Summary: [oVirt][upgrade-suite] test failing due to "waiting for service \"service-test\" to have a load balancer"
Product: OpenShift Container Platform Reporter: Gal Zaidman <gzaidman>
Component: Cluster Version OperatorAssignee: Over the Air Updates <aos-team-ota>
Status: CLOSED DUPLICATE QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: aos-bugs, ccoleman, eparis, jack.ottofaro, jokerman, lmohanty, skuznets, sponnaga, wking
Target Milestone: ---   
Target Release: 4.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-23 18:41:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gal Zaidman 2020-06-22 14:07:55 UTC
Description of problem:
On oVirt upgrade suite[1] we see the failure:

fail [github.com/openshift/origin/test/e2e/upgrade/service/service.go:68]: Unexpected error:
    <*errors.errorString | 0xc0024b4b60>: {
        s: "timed out waiting for service \"service-test\" to have a load balancer",
    }
    timed out waiting for service "service-test" to have a load balancer

on the test case:
Cluster should remain functional during upgrade

This is because oVirt doesn't provide a load balancer (not a cloud).
My suggestion is to skip that part of the test for ovirt platform.

[1] https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-ovirt-upgrade-4.4-stable-to-4.5-ci/1274323818537553920
[2] https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/origin-ci-test/logs/release-openshift-ocp-installer-e2e-ovirt-upgrade-4.5-stable-to-4.6-ci/1274323818566914048

Comment 1 Steve Kuznetsov 2020-06-25 18:07:00 UTC
Can we move this to whatever component actually owns this work? This has nothing to do with DPTP.

Comment 3 W. Trevor King 2020-06-25 23:40:46 UTC
> This is because oVirt doesn't provide a load balancer (not a cloud). My suggestion is to skip that part of the test for ovirt platform.

Clayton, [1] is your code.  I bet you have opinions on what to do for oVirt's lack of cluster-managed LBs.

[1]: https://github.com/openshift/origin/blame/b198d76e6c5ce1423a1e5380c21583ae30eb3055/test/e2e/upgrade/service/service.go#L67-L68

Comment 4 Gal Zaidman 2020-06-29 11:12:55 UTC
*** Bug 1849687 has been marked as a duplicate of this bug. ***

Comment 5 W. Trevor King 2020-07-06 22:08:36 UTC
Moving to ASSIGNED, and marking NEEDINFO, until Clayton says whether he thinks a skip is appropriate or not.

Comment 6 Clayton Coleman 2020-07-09 14:01:47 UTC
Ovirt should add a skip into the service load balancer test, yes.  But I'm somewhat surprised one isn't already there.

Comment 7 W. Trevor King 2020-07-10 21:43:47 UTC
Ok, moving back to NEW.  We'll assign this next sprint and figure out a way to get the service load balancer test to skip platforms which do not implement managed load balancers.

Comment 8 Jack Ottofaro 2020-07-30 20:10:00 UTC
We do not have time to fix the bug in this sprint as we are working on higher priority bugs and features.  Hence we are adding UpcomingSprint now, and we'll revisit this in the next sprint.

Comment 9 W. Trevor King 2020-08-06 17:07:48 UTC
Seen in Azure, for 4.4.6 -> 4.4.16 [1].  We may want to raise the timeouts for platforms that do have load balancers?  Or maybe there's just an acceptable amount of slow-platform flake we don't care about.  Anyhow, this bug is about platforms which do not support load-balancers at all.

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-azure/1290896319816142848

Comment 10 Lalatendu Mohanty 2020-08-21 19:01:56 UTC
Moving to the next sprint as today is the end of sprint.

Comment 11 W. Trevor King 2020-09-13 04:53:06 UTC
Still haven't gotten around to this.  I'm dropping priority to medium, because "high" did not seem compatible with "keeps getting punted to future sprints".  But it would be really nice to have update CI for non-LB platforms, so feel free to make a case for why this should move back up in the queue.

Comment 12 W. Trevor King 2020-09-22 21:31:12 UTC
We really want this for oVirt, etc. update CI.  But not strictly a 4.6 GA blocker so punting to 4.7.  We can pull it back to 4.6 if we have a PR up before 4.6 forks off.

Comment 13 W. Trevor King 2020-10-04 02:40:17 UTC
Comment 12 is still current.

Comment 14 Gal Zaidman 2020-10-11 07:06:07 UTC
David Edas created a patch to skip the test for oVirt and now we have passing upgrade jobs finally,
I belive we can close this,
See:
 - https://bugzilla.redhat.com/show_bug.cgi?id=1886007
 - https://github.com/openshift/origin/pull/25582

Comment 15 Lalatendu Mohanty 2020-10-23 18:41:08 UTC

*** This bug has been marked as a duplicate of bug 1886007 ***