Bug 1849850

This looks like the same issue as the referenced issue which was fixed in 4.40.7 [1]


Maybe it can be retested. The function "readinto" has been added and it is not related to the libvirt sparseness issue.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1798175

(In reply to Steven Rosenberg from comment #1)
> This looks like the same issue as the referenced issue which was fixed in
> 4.40.7 [1]
> 
> 
> Maybe it can be retested. The function "readinto" has been added and it is
> not related to the libvirt sparseness issue.
> 
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1798175

Retested, issue was not reproduced:
ovirt-engine-4.4.1.8-0.7.el8ev
vdsm-4.40.22-1.el8ev.x86_64
libvirt-daemon-6.0.0-25.module+el8.2.1+7154+47ffd890.x86_64
qemu-kvm-4.2.0-29.module+el8.2.1+7297+a825794d.x86_64

Hello,

I still experience this bug in oVirt 4.4.1 with vdsm version vdsm-4.40.22-1.el8.x86_64

ovirt-engine-4.4.1.10-1.el8.noarch (hosted engine)

on host involved in import

vdsm-4.40.22-1.el8.x86_64
libvirt-daemon-6.0.0-17.el8.x86_64
qemu-kvm-4.2.0-19.el8.x86_64


[    0.5] preparing for copy
[    0.5] Copying disk 1/1 to /rhev/data-center/mnt/glusterSD/10.0.4.11:_engine/bd15bfa7-67f7-494a-a0b6-138187247541/images/dd414a78-a139-4ef9-9f5a-a785e06028bd/9197763a-9ccd-474d-acb9-8ad3c4afc4d9
Traceback (most recent call last):
  File "/usr/libexec/vdsm/kvm2ovirt", line 23, in <module>
    kvm2ovirt.main()
  File "/usr/lib/python3.6/site-packages/vdsm/kvm2ovirt.py", line 269, in main
    handle_path(con, diskno, src, dst, options)
  File "/usr/lib/python3.6/site-packages/vdsm/kvm2ovirt.py", line 233, in handle_path
    download_disk(vmAdapter, physical, physical, dst, options.bufsize)
  File "/usr/lib/python3.6/site-packages/vdsm/kvm2ovirt.py", line 163, in download_disk
    op.run()
  File "/usr/lib64/python3.6/site-packages/ovirt_imageio/_internal/ops.py", line 51, in run
    self._run()
  File "/usr/lib64/python3.6/site-packages/ovirt_imageio/_internal/ops.py", line 137, in _run
    self._receive_chunk(count)
  File "/usr/lib64/python3.6/site-packages/ovirt_imageio/_internal/ops.py", line 152, in _receive_chunk
    n = self._src.readinto(v)
AttributeError: 'VMAdapter' object has no attribute 'readinto'

Thanks Jiří.
It indeed looks different than bz 1798175 (this one is about VMAdapter while the fix for bz 1798165 added 'readinto' to StreamAdapter).
To reproduce this we need the disk(s) of the source VM to either be placed in a block storage or on a local path on the host (that is not within libvirt's storage pool).

Hello Arik, the source disk is of this vm resides on lvm (on remote kvm of course). What exactly should I do to help debug this? Should I dd this disk to some lvm volume or file on oVirt host? It is possible but what next?

(In reply to Jiří Sléžka from comment #5)
> Hello Arik, the source disk is of this vm resides on lvm (on remote kvm of
> course). What exactly should I do to help debug this? Should I dd this disk
> to some lvm volume or file on oVirt host? It is possible but what next?

Thanks for the additional information.
I think it should be easy for us to reproduce now, no need for additional resources.

just for record, source kvm is CentOS7, vm's definition is this

<domain type='kvm' id='5'>
  <name>dione</name>
  <uuid>518fc09f-ef0d-4f81-a217-b49dadb4c404</uuid>
  <description>dione.slu.cz</description>
  <memory unit='KiB'>1048576</memory>
  <currentMemory unit='KiB'>1048576</currentMemory>
  <vcpu placement='static'>2</vcpu>
  <resource>
    <partition>/machine</partition>
  </resource>
  <os>
    <type arch='x86_64' machine='pc-i440fx-rhel7.0.0'>hvm</type>
    <boot dev='hd'/>
  </os>
  <features>
    <acpi/>
    <apic/>
  </features>
  <cpu mode='custom' match='exact' check='full'>
    <model fallback='forbid'>Conroe</model>
    <feature policy='require' name='x2apic'/>
    <feature policy='require' name='hypervisor'/>
  </cpu>
  <clock offset='utc'>
    <timer name='rtc' tickpolicy='catchup'/>
    <timer name='pit' tickpolicy='delay'/>
    <timer name='hpet' present='no'/>
  </clock>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>restart</on_crash>
  <pm>
    <suspend-to-mem enabled='no'/>
    <suspend-to-disk enabled='no'/>
  </pm>
  <devices>
    <emulator>/usr/libexec/qemu-kvm</emulator>
    <disk type='block' device='disk'>
      <driver name='qemu' type='raw' cache='none' io='native'/>
      <source dev='/dev/vmdata/dione'/>
      <backingStore/>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </disk>
    <disk type='file' device='cdrom'>
      <driver name='qemu'/>
      <target dev='hda' bus='ide'/>
      <readonly/>
      <alias name='ide0-0-0'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
    <controller type='usb' index='0' model='ich9-ehci1'>
      <alias name='usb'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x7'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci1'>
      <alias name='usb'/>
      <master startport='0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0' multifunction='on'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci2'>
      <alias name='usb'/>
      <master startport='2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x1'/>
    </controller>
    <controller type='usb' index='0' model='ich9-uhci3'>
      <alias name='usb'/>
      <master startport='4'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x2'/>
    </controller>
    <controller type='pci' index='0' model='pci-root'>
      <alias name='pci.0'/>
    </controller>
    <controller type='ide' index='0'>
      <alias name='ide'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
    </controller>
    <controller type='virtio-serial' index='0'>
      <alias name='virtio-serial0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </controller>
    <interface type='bridge'>
      <mac address='52:54:00:22:d1:84'/>
      <source bridge='br-vlan902'/>
      <target dev='vnet0'/>
      <model type='virtio'/>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
    </interface>
    <serial type='pty'>
      <source path='/dev/pts/0'/>
      <target type='isa-serial' port='0'>
        <model name='isa-serial'/>
      </target>
      <alias name='serial0'/>
    </serial>
    <console type='pty' tty='/dev/pts/0'>
      <source path='/dev/pts/0'/>
      <target type='serial' port='0'/>
      <alias name='serial0'/>
    </console>
    <channel type='unix'>
      <source mode='bind' path='/var/lib/libvirt/qemu/channel/target/domain-5-dione-new/org.qemu.guest_agent.0'/>
      <target type='virtio' name='org.qemu.guest_agent.0' state='disconnected'/>
      <alias name='channel0'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>
    <channel type='spicevmc'>
      <target type='virtio' name='com.redhat.spice.0' state='disconnected'/>
      <alias name='channel1'/>
      <address type='virtio-serial' controller='0' bus='0' port='2'/>
    </channel>
    <input type='tablet' bus='usb'>
      <alias name='input0'/>
      <address type='usb' bus='0' port='1'/>
    </input>
    <input type='mouse' bus='ps2'>
      <alias name='input1'/>
    </input>
    <input type='keyboard' bus='ps2'>
      <alias name='input2'/>
    </input>
    <graphics type='spice' port='5900' autoport='yes' listen='127.0.0.1'>
      <listen type='address' address='127.0.0.1'/>
      <image compression='off'/>
    </graphics>
    <video>
      <model type='qxl' ram='65536' vram='65536' vgamem='16384' heads='1' primary='yes'/>
      <alias name='video0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
    </video>
    <redirdev bus='usb' type='spicevmc'>
      <alias name='redir0'/>
      <address type='usb' bus='0' port='2'/>
    </redirdev>
    <redirdev bus='usb' type='spicevmc'>
      <alias name='redir1'/>
      <address type='usb' bus='0' port='3'/>
    </redirdev>
    <memballoon model='virtio'>
      <stats period='5'/>
      <alias name='balloon0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/>
    </memballoon>
  </devices>
  <seclabel type='dynamic' model='selinux' relabel='yes'>
    <label>system_u:system_r:svirt_t:s0:c73,c919</label>
    <imagelabel>system_u:object_r:svirt_image_t:s0:c73,c919</imagelabel>
  </seclabel>
  <seclabel type='dynamic' model='dac' relabel='yes'>
    <label>+107:+107</label>
    <imagelabel>+107:+107</imagelabel>
  </seclabel>
</domain>

This bug is assigned to me, but I'm the wrong Steven Rosenberg.

(In reply to Steven Rosenberg from comment #8)
> This bug is assigned to me, but I'm the wrong Steven Rosenberg.

It is assigned to me. Thank you.

Verified:
ovirt-engine-4.4.2.3-0.6.el8ev
vdsm-4.40.26-1.el8ev.x86_64
libvirt-daemon-6.0.0-25.module+el8.2.1+7154+47ffd890.x86_64
qemu-kvm-4.2.0-29.module+el8.2.1+7297+a825794d.x86_64
KVM server: 
Red Hat Enterprise Linux release 8.2 (Ootpa)
libvirt-daemon-6.0.0-25.module+el8.2.1+7154+47ffd890.x86_64
qemu-kvm-4.2.0-29.module+el8.2.1+7297+a825794d.x86_64

1. Import KVM VM with block storage.
2. Verify import succeeds, run VM and verify VM is running and OS booted.
3. Import the same VM again as clone.
4. Verify import succeeds, run VM and verify VM is running and OS booted.
5. Also verified the next table from:
https://bugzilla.redhat.com/show_bug.cgi?id=1663135#c72

This bugzilla is included in oVirt 4.4.2 release, published on September 17th 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.