Bug 1850025

Does this even work if you include them in appstream-data? There's no code in gnoem-software to read screenshots out of /usr for flatpaks. It's not something we've ever considered, nor do I think it's a good idea.

Hi kalev, I think the question regarding screenshots is something you can possibly answer, so adding needinfo.

(In reply to Martin Krajnak from comment #3)
> Hi kalev, I think the question regarding screenshots is something you can
> possibly answer, so adding needinfo.

Hi Martin -- sorry for the delay, I was on PTO. I am indeed the right person to answer this :)

What we need is for the flatpak runtime and sdk to include the correct metainfo. This should get picked up automatically and automatically included as appstream data in the flatpak remote. We shouldn't need any appstream-data package changes here.

I'll investigate a bit how to do this best. appstream-data isn't the correct component here but I am not entirely sure yet where the fix should live. I'll update the component when we have come up with a plan for this.

I discussed this with Owen and we came up with a plan to include the appstream metainfo in flatpak-runtime-config.

I went ahead and did that in Fedora (https://src.fedoraproject.org/rpms/flatpak-runtime-config/c/520c65dbf85190cbfdc37a0390a2250cacadac53?branch=f32), and rebuilt the runtime and SDK flatpaks (https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2020-b63ed36598, https://bodhi.fedoraproject.org/updates/FEDORA-FLATPAK-2020-095cafd498)

For RHEL, I commited a similar change to flatpak-runtime-config (with a slightly more useful license field, <project_license>https://www.redhat.com/en/about/red-hat-end-user-license-agreements#</project_license>). I'd link to the commit if I could remember where the RHEL dist-git web UI lives :)

Anyway, what's missing here is that we need new flatpak runtime and SDK builds that include the flatpak-runtime-config changes. I'll be on PTO for two weeks and back on 17 August, and I can do them then, or if there's urgency in getting them out, Owen Taylor should be able to help here.

Sorry, missed this earlier - I think we can still get the module rebuilt and signed. Could someone explain, however, how this blocks #1815502 - should't GNOME Software still be able to update an installed Flatpak runtime without appstream data?

If I understand correctly, this blocks bz1815502 because without appstream metadata I am not able to install a flatpak/runtime from the redhat remote, thus I am not able to verify the newly added webauth support that was introduced to gnome-software. I am not sure about updates, I think Kalev will know the answer for this.

Yep, I think it only blocks the QA testing for https://bugzilla.redhat.com/show_bug.cgi?id=1815502 but nothing else. Updates should work just fine without the extra metadata.

(In reply to Kalev Lember from comment #5)

> Anyway, what's missing here is that we need new flatpak runtime and SDK
> builds that include the flatpak-runtime-config changes. I'll be on PTO for
> two weeks and back on 17 August, and I can do them then, or if there's
> urgency in getting them out, Owen Taylor should be able to help here.

Hi Kalev, please what is the status on this ?

Still the same -- the appdata file is commited to git; I don't know how to do the actual build for the runtime and sdk and need to find Owen to figure out how to do that.