Bug 1850401

Summary:	Remove isDeferringFileVolumePreallocationSupported flag
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Shenitzky <eshenitz>
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shir Fishbain <sfishbai>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4.0	CC:	bugs, mtessun, nsoffer, sfishbai, tnisan
Target Milestone:	ovirt-4.4.2	Flags:	pm-rhel: ovirt-4.4+ mtessun: planning_ack+
Target Release:	4.4.2.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.2.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-09-22 10:22:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2020-06-24 09:19:59 UTC

Description of problem:

When VDSM patch - https://gerrit.ovirt.org/#/c/109793/ will be merged
There will be no need to use the isDeferringFileVolumePreallocationSupported database config value.

The following flows should be tested once the use of this flag is removed - 

In all the flows the VM/template has a raw preallocated disk.

 - Clone VM
 - Create Template from VM with preallocated disk
 - Create template from snapshot 
 - Create VM from tempalte as 'clone' with disk format raw
 - Create VM from snapshot
 - Copy floating Disk
 - Copy VM Disk
 - Copy template disk
 - Import VM with raw-preallocated disk
 - Live/cold migrate raw-preallocated disk

The validation is that the raw-preallocated disk keeps the disk format/type after performing the above operations.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Nir Soffer 2020-06-24 12:59:24 UTC

(In reply to Eyal Shenitzky from comment #0)
> The validation is that the raw-preallocated disk keeps the disk format/type
> after performing the above operations.

If vdsm does not report "deferred_preallocation" capability engine creates
a thin disk instead of preallocated?

This is a bad bug on engine side if it does. "deferred_preallocation" is 
a performance optimization and should not affect image properties.

If this is the case we need to fix this in engine before we remove
the capability in vdsm.

Comment 2 Lukas Svaty 2020-09-22 10:22:16 UTC

CLOSING low QE severity 4.4.2 issuees with NEXT_RELESE. If you believe these bugs indeed require QE Verification feel free to reopen.