Bug 1850440

Description of problem:
Disabling "logs" feature in foreman-proxy of Satellite or a Capsule, API request:

/api/statuses

returns 500 error.

The reason is evident from source code:

https://github.com/theforeman/foreman/blob/develop/app/services/ping.rb#L66 :

    def statuses_smart_proxies
      results = []
      SmartProxy.all.includes(:features).map do |proxy|
        start = Time.now
        begin
          version = proxy.statuses[:version].version['version']
          features = proxy.statuses[:version].version['modules']
          failed_features = proxy.statuses[:logs].logs.failed_modules
..

The proxy without logs feature has proxy.statuses without :logs :-/

The line should be like:

          failed_features = (proxy.statuses[:logs].nil? ? {} : proxy.statuses[:logs].logs.failed_modules)


Version-Release number of selected component (if applicable):
Sat6.7


How reproducible:
100%


Steps to Reproduce:
1. Have an external Capsule
2. On the Capsule, disable "logs" feature:
satellite-installer --scenario=capsule --foreman-proxy-logs=false

3. Check statuses API call on Satellite:

curl -L -u admin:mysecret007 http://$(hostname -f)/api/statuses


Actual results:
{
  "error": {"message":"Internal Server Error: the server was unable to finish the request. This may be caused by unavailability of some required service, incorrect API call or a server-side bug. There may be more information in the server's logs."}
}


Expected results:
{"results":{ ... (some usual output)


Additional info: