Bug 1851205 (AusweisApp2)
Summary: | Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Björn 'besser82' Esser <besser82> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | lukaskandler, package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-21 01:10:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Björn 'besser82' Esser
2020-06-25 18:53:55 UTC
=== Updated package === Changelog: * Thu Jun 25 2020 Björn Esser <besser82> - 1.20.1-0.2 - Adaptions for building on EPEL Urls: Spec URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2-1.20.1-0.2.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46155735 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46155737 === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser <besser82> - 1.20.1-0.3 - Use ninja-build instead of GNU Make to speed up the build a bit Urls: Spec URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/blob/master/f/AusweisApp2-1.20.1-0.3.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46158165 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46158009 === Fixed urls === Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.3.fc33.src.rpm === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser <besser82> - 1.20.1-0.4 - Use a macro for lowercase package name Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.4.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161110 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161112 === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser <besser82> - 1.20.1-0.5 - Add generated man-page Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.5.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161533 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46161535 === Updated package === Changelog: * Thu Jun 25 2020 Björn Esser <besser82> - 1.20.1-0.6 - Use '--help-all' option when generating man-page - Split build of Doxygen API docs from building user docs Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.6.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46162604 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46162606 === Updated package === Changelog: * Fri Jun 26 2020 Björn Esser <besser82> - 1.20.1-0.7 - Make sure permissions of the documentation files are correct - Remove hidden files in documentation - Drop 'LICENSE.officially.txt', as it only applies to binary copies, which are distributed on behalf of the federal government of Germany Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.7.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46184240 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46184244 === Updated package === Changelog: * Fri Jun 26 2020 Björn Esser <besser82> - 1.20.1-0.8 - Ensure archful packages always require equal architecture Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.8.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46194548 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46194554 === Updated package === Changelog: * Fri Jun 26 2020 Björn Esser <besser82> - 1.20.1-0.9 - Also obsolete package with %%{name} previous to this package version Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.9.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46195564 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46195580 - AUTHORS should be included as %doc, not %license LGTM, should be approved after Spot clears the license. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [Probably]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 2546 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/AusweisApp2/review- AusweisApp2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in AusweisApp2-data [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: # %%define with lazy expansion is used here intentionally, because, %define __spec_install_post %{?__debug_package:%{__debug_install_post}} %{__arch_install_post} %{__os_install_post} bindir="%{buildroot}%{_bindir}" fipsdir="%{buildroot}%{_libdir}/fipscheck" mkdir -p "$fipsdir" fipshmac -d "$fipsdir" "$bindir/%{name}" %{nil} [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 190259200 bytes in /usr/share AusweisApp2-doc-api-1.20.1-0.9.fc33.x86_64.rpm:190197760 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. === Updated package === Changelog: * Sat Jul 04 2020 Björn Esser <besser82> - 1.20.1-0.10 - Add license text in English language Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/AusweisApp2-1.20.1-0.10.fc33.src.rpm Scratch build: Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=46565229 EPEL8: https://koji.fedoraproject.org/koji/taskinfo?taskID=46565243 Lifting FE-Legal as per [1] EUPL v1.2 is confirmed to be a "good" license. [1] https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/message/B4P7Z5TDWMXEZYGGZEAQ7APPOQVKIKNF/ Again: - AUTHORS should be included as %doc, not %license Package approved, please fix this before import. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/AusweisApp2 FEDORA-2020-5ebe8ea9fb has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5ebe8ea9fb FEDORA-EPEL-2020-0c4a8e2bde has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-0c4a8e2bde FEDORA-2020-0796d826d6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0796d826d6 FEDORA-2020-0796d826d6 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0796d826d6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0796d826d6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-0c4a8e2bde has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-0c4a8e2bde See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-5ebe8ea9fb has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-5ebe8ea9fb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5ebe8ea9fb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-5ebe8ea9fb has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-0796d826d6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0796d826d6 FEDORA-EPEL-2020-0c4a8e2bde has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-0c4a8e2bde FEDORA-2020-0796d826d6 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0796d826d6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0796d826d6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-0c4a8e2bde has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-0c4a8e2bde See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-0c4a8e2bde has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-0796d826d6 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2020-93bcbe0dab has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-93bcbe0dab FEDORA-EPEL-2020-93bcbe0dab has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-93bcbe0dab See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-93bcbe0dab has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. |