Bug 1851407

Summary:	daemonsets fail to rollout during upgrade
Product:	OpenShift Container Platform	Reporter:	Tomáš Nožička <tnozicka>
Component:	kube-controller-manager	Assignee:	Tomáš Nožička <tnozicka>
Status:	CLOSED ERRATA	QA Contact:	zhou ying <yinzhou>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.5	CC:	aos-bugs, bparees, deads, maszulik, mfojtik, tnozicka, wking, yinzhou
Target Milestone:	---	Keywords:	Reopened
Target Release:	4.4.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: DaemonSet recreation Consequence: DaemonSet could get stuck for 5 minutes while expectations expire. Fix: DaemonSet controller now clears expectations on recreate. Result: Doesn't get stuck.	Story Points:	---
Clone Of:	1845242	Environment:
Last Closed:	2020-07-28 12:37:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1845242
Bug Blocks:

Comment 4 zhou ying 2020-07-17 10:09:15 UTC

Checked with unit test , no issue found:

[root@dhcp-140-138 origin]# git branch
  master
  release-3.9
* release-4.4
  release-4.5
[root@dhcp-140-138 origin]#  cd vendor/k8s.io/kubernetes/pkg/controller/daemon
[root@dhcp-140-138 daemon]# go test -v -run TestExpectationsOnRecreate
...
I0717 18:08:26.602859   14416 shared_informer.go:197] Waiting for caches to sync for test dsc
I0717 18:08:26.703133   14416 shared_informer.go:204] Caches are synced for test dsc 
--- PASS: TestExpectationsOnRecreate (0.41s)
PASS
ok  	k8s.io/kubernetes/pkg/controller/daemon	0.429s

Comment 6 errata-xmlrpc 2020-07-28 12:37:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3075