Bug 1851586

Summary:	Review Request: pulseaudio-equalizer-ladspa - Systemwide Equalizer for Pulseaudio
Product:	[Fedora] Fedora	Reporter:	seanmottles
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-06-30 10:11:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description seanmottles 2020-06-27 08:54:27 UTC

This is my first package and I am seeking a sponsor.

Spec URL: https://download.copr.fedorainfracloud.org/results/sesmca/pulseaudio-equalizer-ladspa/fedora-32-x86_64/01506707-pulseaudio-equalizer-ladspa/pulseaudio-equalizer-ladspa.spec

SRPM URL: https://download.copr.fedorainfracloud.org/results/sesmca/pulseaudio-equalizer-ladspa/fedora-32-x86_64/01506707-pulseaudio-equalizer-ladspa/pulseaudio-equalizer-ladspa-3.0.2-1.fc32.src.rpm

Description: PulseAudio Equalizer is a 15 bands system wide equalizer, that means
any application that is using PulseAudio, will benefit from the sound
improvement.

COPR Repository: https://copr.fedorainfracloud.org/coprs/sesmca/pulseaudio-equalizer-ladspa/

Fedora Account System Username: sesmca

Comment 1 Robert-André Mauchin 🐧 2020-06-30 10:00:42 UTC

Something is wrong here: you do not link to upstream but to your own repo, you just unzip an archive coming from somewhere not mentioned, you don't install from Source but from unzipping binaries directly into buildroot.

You should point to upstream Github and follow their install instruction with meson. 
Also respect the format for the changelog entry.
Your package is missing a description entry.
Don't mix tabs and spaces.
Please get to know the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/

Name:           pulseaudio-equalizer-ladspa
Version:        3.0.2
Release:        1%{?dist}
Summary:        A 15-band equalizer for PulseAudio

License:        GPLv3+
URL:            https://github.com/pulseaudio-equalizer-ladspa/equalizer
Source0:        %url/archive/v%{version}/%{name}-%{version}.tar.gz
BuildArch:      noarch

BuildRequires:  desktop-file-utils
BuildRequires:  python3-devel
BuildRequires:  glib2-devel
BuildRequires:  meson
Requires:       pulseaudio-utils
Requires:       gtk3
Requires:       python3-gobject
Requires:       ladspa-swh-plugins
Requires:       bc

%description
A LADSPA based multiband equalizer approach for getting better sound out of
pulseaudio.

%prep
%autosetup -n equalizer-%{version}

%build
%meson
%meson_build

%install
%meson_install

desktop-file-validate %{buildroot}%{_datadir}/applications/com.github.pulseaudio-equalizer-ladspa.Equalizer.desktop

%files
%license LICENSE
%doc README.md
%{_bindir}/pulseaudio-equalizer
%{_bindir}/pulseaudio-equalizer-gtk
%{_datadir}/%{name}/
%{_datadir}/applications/com.github.pulseaudio-equalizer-ladspa.Equalizer.desktop
%{python3_sitearch}/pulseeq/

%changelog
* Tue Jun 30 11:43:43 CEST 2020 Sean Mottles <seanmottles> - 3.0.2-1
- Initial package