Bug 1851856

(In reply to Asher Shoshan from comment #0)
> Description of problem:
> When deploying CNV 2.4, virt-operator requires PriorityClass
> (kubevirt-cluster-critical), not yet in cluster.  This is created only later
> by HCO operator, when hco CR is created (after virt-operator is up and
> running).

This is exactly as we designed it,
why do you think it's a bug?

(In reply to Simone Tiraboschi from comment #1)
> (In reply to Asher Shoshan from comment #0)
> > Description of problem:
> > When deploying CNV 2.4, virt-operator requires PriorityClass
> > (kubevirt-cluster-critical), not yet in cluster.  This is created only later
> > by HCO operator, when hco CR is created (after virt-operator is up and
> > running).
> 
> This is exactly as we designed it,
> why do you think it's a bug?

If your script is waiting for HCO operator to become ready, and then creating the HCO cr -- then it's a deadlock.

Created attachment 1699157 [details]
Failed CSV

This is more a GUI glitch than a real dedlock.
HCO pod will become ready because it's checking conditions on the CR for virt-operator that doesn't exist before the user creates HCO CR so HCO pod will be ready for sure.

The real issue here is that OLM will try to start virt-operator and it will fail due to the lack of its priority class.
So, after a certain timeout the CSV will be declared as failed and this can confuse the user although the user will be still allowed to create the CR for HCO exactly as documented and this is enough to trigger the creation of the priority class and get it up and running.

I'm attaching a screenshot with the issue.

The only option that I see is trying to create KV priority class on HCO start.

(In reply to Simone Tiraboschi from comment #4)
> This is more a GUI glitch than a real dedlock.
> HCO pod will become ready because it's checking conditions on the CR for
> virt-operator that doesn't exist before the user creates HCO CR so HCO pod
> will be ready for sure.
> 
> The real issue here is that OLM will try to start virt-operator and it will
> fail due to the lack of its priority class.
> So, after a certain timeout the CSV will be declared as failed and this can
> confuse the user although the user will be still allowed to create the CR
> for HCO exactly as documented and this is enough to trigger the creation of
> the priority class and get it up and running.
> 
> I'm attaching a screenshot with the issue.
> 
> The only option that I see is trying to create KV priority class on HCO
> start.

An end-user UI deploying CNV package, does not need to hurry-up, and create HCO cr, in order to rectify the virt-operator pending start.
He usually waits, until the UI, shows the operator installed, then he will proceed to create all CR's.
More than that, if he hadn't created the HCo cr on time, UI deployment would enter "failed" state.

CLI deployment scripts, do not wait for OLM to successfully deploy all underlying deployment/pods of the CSV, and once HCO operator pod is ready, it will create the HCO cr (rectify the pending state).

The missing priorityClass, should be created by HCO operator (implemented as an init-container), or by a separate OLM deploy/pod.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3194