Bug 185205

Summary: Review Request: nqc
Product: [Fedora] Fedora Reporter: Simon Perreault <nomis80>
Component: Package ReviewAssignee: John Mahowald <jpmahowald>
Status: CLOSED DUPLICATE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: rvinyard
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-08-20 08:58:38 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description Simon Perreault 2006-03-11 14:33:04 EST
Spec Name or Url: http://nomis80.org/rpms/SPECS/nqc.spec
SRPM Name or Url: http://nomis80.org/rpms/SRPMS/nqc-3.1.r4-1.src.rpm
Description:
Not Quite C is a simple language with a C-like syntax that can be used to
program Lego's RCX programmable brick (from the Mindstorms set).
Comment 1 John Mahowald 2006-03-17 12:29:40 EST
How timely, working a bit with Mindstorms at the moment.

Doesn't build on x86_64:
compiler/Error.h:121: error: cast from 'const char*' to 'int' loses precision
Comment 2 Simon Perreault 2006-03-17 16:21:22 EST
ExcludeArch: x86_64 
 
SRPM: http://nomis80.org/rpms/SRPMS/nqc-3.1.r4-2.src.rpm 
SPEC: http://nomis80.org/rpms/SPECS/nqc.spec 
Comment 3 Simon Perreault 2006-04-04 19:02:08 EDT
Can any reviewer approve this package please? 
Comment 4 John Mahowald 2006-04-23 16:18:22 EDT
Remember to, after creating the bugzilla entry, file a bug and make it block
FE-ExcludeArch-x64 as per the review guidelines

Good:

- rpmlint checks clean
- package meets naming guidelines
- package meets packaging guidelines
- license (MPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86) (but not on x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED
Comment 5 Rick L Vinyard Jr 2006-08-06 16:18:11 EDT
Just checking on the status of this.
Comment 6 Rick L Vinyard Jr 2006-08-12 13:54:56 EDT
I'd really like to see nqc in FE. If there's no interest or time to move this
forward, I'll offer to adopt it.
Comment 7 Simon Perreault 2006-08-12 14:52:59 EDT
Go ahead and adopt it. I've got no time now and in the foreseable future to work
on this.
Comment 8 Jason Tibbitts 2006-08-12 18:28:58 EDT
Rick, go ahead and make a new submission for your package.  You can close this
as a duplicate of the new bug.
Comment 9 Rick L Vinyard Jr 2006-08-15 23:31:32 EDT
Will do.
Comment 10 Rick L Vinyard Jr 2006-08-19 21:07:42 EDT
(In reply to comment #8)
> Rick, go ahead and make a new submission for your package.  You can close this
> as a duplicate of the new bug.

Bug #203265 is the new submission. I don't have permissions to close this bug
though; someone else will have to.
Comment 11 Simon Perreault 2006-08-20 08:58:38 EDT

*** This bug has been marked as a duplicate of 203265 ***