Bug 185262
| Summary: | Review Request: kchmviewer - CHM viewer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> | ||||
| Component: | Package Review | Assignee: | John Mahowald <jpmahowald> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jose.p.oliveira.oss, rdieter | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | Flags: | jwboyer:
fedora-cvs+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-05-16 23:29:09 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 163779 | ||||||
| Attachments: |
|
||||||
|
Description
Patrice Dumas
2006-03-12 22:14:39 UTC
Thanks to Rex Dieter I have understood why it failed with kde support. Here is an updated srpm with kde support: http://www.environnement.ens.fr/perso/dumas/fc-srpms/kchmviewer-2.0-2.src.rpm Here is an updated version with use of update-desktop-database: http://www.environnement.ens.fr/perso/dumas/fc-srpms/kchmviewer-2.0-3.src.rpm rpmlint checks return: E: kchmviewer old-menu-entry /usr/share/applnk/kchmviewer.desktop Not necessary with it already in /usr/share/applications - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file ok %description's a bit long, but oh well. APPROVED I am importing the package now. Should I remove the /usr/share/applnk/kchmviewer.desktop file? Patrice, just use desktop-file-install --delete-original ... Oops, better yet, change:
desktop-file-install --vendor fedora \
--dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
--add-category X-Fedora \
kio-msits/kchmviewer.desktop
to
desktop-file-install --vendor fedora \
--dir ${RPM_BUILD_ROOT}%{_datadir}/applications \
--add-category X-Fedora \
--delete-original \
$RPM_BUILD_ROOT%{_datadir}/applnk/*/kchmviewer.desktop
package is in extras. Please remember to close package reviews once approved and imported into cvs etc etc Re-opening this until Patrice can: * look at comment #6 * build the package for FC-4 and FC-5 (branches already created) I was on vacations, I hope everything is sorted out now. The issue raised in the comment #6 should be fixed, I updated owners.list, and it is built for FC-4 FC-5. Created attachment 129378 [details]
Minor patch
Thanks. Now you can update the package to version 2.5 :)
You need to apply the attached patch (at least for FC-5) and add the following
line to the specfile (%files section):
%{_datadir}/icons/crystalsvg/*/apps/kchmviewer.png
jpo
Package Change Request ====================== Package Name: kchmviewer Updated Fedora Owners: pertusus[ AT ]free.fr, jpo[ AT ]di.uminho.pt |