Bug 185266
| Summary: | Review Request: perl-Text-CHM Perl extension for handling MS Compiled HtmlHelp Files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrice Dumas <pertusus> |
| Component: | Package Review | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-31 20:26:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Patrice Dumas
2006-03-12 23:06:54 UTC
Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds OK on FC5 (i386) and in mock for rawhide (i386) - BR's OK - no locales, libraries, pkgconfigs, or subpackages to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no desktop file needed - no scriptlets Suggestions: - use the DESCRIPTION section from the manpage for %description Notes: - the CPAN test results do not inspire confidence in this module (4 testers, 4 FAILs) http://cpantesters.perl.org/show/Text-CHM.html#Text-CHM-0.01 Approved. I changed the description based on the man page, thanks for the idea. The failed test don't seem to be problematic to me as the build fails because chmlib.h isn't found. It builds in devel. Please add the package in owners.list done. Thanks |