Bug 1852762

Summary:	[RHEL8.6]Error message need update when boot guest with '-M pc -cpu Icelake-Server,+intel-pt'
Product:	Red Hat Enterprise Linux 8	Reporter:	Yumei Huang <yuhuang>
Component:	qemu-kvm	Assignee:	Virtualization Maintenance <virt-maint>
qemu-kvm sub component:	CPU Models	QA Contact:	liunana <nanliu>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	ailan, chayang, ddepaula, juzhang, nanliu, virt-maint, yfu, yuhuang
Version:	8.3	Keywords:	Rebase, Triaged
Target Milestone:	rc
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	qemu-kvm-6.1.0-2.module+el8.6.0+12861+13975d62	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-05-10 13:18:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1997410
Bug Blocks:

Description Yumei Huang 2020-07-01 08:58:40 UTC

Description of problem:
Set pt_mode to 1 on host, boot guest with '-M pc -cpu Icelake-Server,+intel-pt', the error message is 
"qemu-kvm: warning: Intel PT need CPUID leaf 0x14, please set by "-cpu ...,+intel-pt,level=0x14": CPUID.07H:EBX.intel-pt [bit 25]",

but actually it should be "min-level" instead of "level". 

Version-Release number of selected component (if applicable):
qemu-kvm-4.2.0-25.module+el8.3.0+6986+29a4dcd7
kernel: 4.18.0-215.el8.x86_64

How reproducible:
always

Steps to Reproduce:
1. Set pt_mode = 1 on Icelake host first,
# rmmod kvm_intel  
# modprobe kvm_intel pt_mode=1
# cat /sys/module/kvm_intel/parameters/pt_mode 
1

2. Boot guest with '-M pc -cpu Icelake-Server,+intel-pt' or '-M pc -cpu Icelake-Server,+intel-pt,level=0x14', hit warning.


Actual results:
qemu-kvm: warning: Intel PT need CPUID leaf 0x14, please set by "-cpu ...,+intel-pt,level=0x14": CPUID.07H:EBX.intel-pt [bit 25]

Expected results:
The warning message should say min-level=0x14 instead of level=0x14.

Additional info:
1. The issue exists in 8.2.1-av as well as test in https://bugzilla.redhat.com/show_bug.cgi?id=1513681#c72.

Comment 2 Eduardo Habkost 2021-04-12 20:06:12 UTC

Will be fixed by the next QEMU rebase to 5.1.0+

Comment 3 Danilo de Paula 2021-06-11 21:58:08 UTC

We will only rebase on 8.6.

Should we mark ITR 8.6.0 on this one, so it's clear in which version this is supposed to be fixed?

Comment 5 Eduardo Habkost 2021-06-15 18:14:36 UTC

(In reply to Danilo Cesar Lemes de Paula from comment #3)
> We will only rebase on 8.6.
> 
> Should we mark ITR 8.6.0 on this one, so it's clear in which version this is
> supposed to be fixed?

Works for me.

Comment 6 liunana 2021-06-29 11:02:22 UTC

I set ITM to 10 now and we can change it if the code is still not ready at that time. Thanks!


Best regards
Liu Nana

Comment 10 Yanan Fu 2021-10-13 03:06:48 UTC

Set 'Verified:Tested,SanityOnly' as gating test with qemu-kvm-6.1.0-2.module+el8.6.0+12861+13975d62 pass.

Comment 11 liunana 2021-11-08 02:40:51 UTC

Test Env:
  intel-whitley-02.7a2m.lab.eng.bos.redhat.com
  qemu-kvm-6.1.0-2.module+el8.6.0+12861+13975d62.x86_64
  4.18.0-348.4.el8.x86_64


Test steps:
1. Set pt_mode = 1 on Icelake host first,
# rmmod kvm_intel  
# modprobe kvm_intel pt_mode=1
# cat /sys/module/kvm_intel/parameters/pt_mode 
1

2. can get right error info once missing 'min-level=0x14'.
# /usr/libexec/qemu-kvm -M pc -cpu Icelake-Server-noTSX,+intel-pt
qemu-kvm: warning: Intel PT need CPUID leaf 0x14, please set by "-cpu ...,intel-pt=on,min-level=0x14": CPUID.07H:EBX.intel-pt [bit 25]

3. can boot qemu successfully with 'min-level=0x14'.
# /usr/libexec/qemu-kvm -M pc -cpu Icelake-Server-noTSX,+intel-pt,min-level=0x14
VNC server running on ::1:5900



Move this bug to verified now, thanks.

Comment 14 errata-xmlrpc 2022-05-10 13:18:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: virt:rhel and virt-devel:rhel security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:1759