Bug 1852787

Summary:	Should forbidden to create the KubeletConfig object if lack of the evictionSoftGracePeriod when using the soft eviction
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	Node	Assignee:	Harshal Patil <harpatil>
Status:	CLOSED ERRATA	QA Contact:	MinLi <minmli>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4	CC:	aos-bugs, bandrade, chezhang, jokerman, nagrawal
Target Milestone:	---	Keywords:	Reopened
Target Release:	4.5.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	Cause: evictionSoft must be specified with corresponding evictionSoftGracePeriod Consequence: Kubelet will fail to start without valid configuration Fix: During KubeletConfig creation verify that evictionSoft is supplied with corresponding evictionSoftGracePeriod Result: Kubelet should start normally with evictionSoft support	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-17 20:05:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1805019
Bug Blocks:	1852792

Comment 5 MinLi 2020-08-11 06:23:20 UTC

not fix in version : 4.5.0-0.nightly-2020-08-07-024812

$ oc get kubeletconfig worker-kubeconfig-fix -o yaml 
apiVersion: machineconfiguration.openshift.io/v1
kind: KubeletConfig
metadata:
  creationTimestamp: "2020-08-11T06:17:18Z"
  finalizers:
  - 2291b9e1-6bbf-4ad8-982f-5d1c5285b88e
  generation: 1
  managedFields:
  - apiVersion: machineconfiguration.openshift.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:spec:
        .: {}
        f:kubeletConfig:
          .: {}
          f:evictionPressureTransitionPeriod: {}
          f:evictionSoft: {}
        f:machineConfigPoolSelector:
          .: {}
          f:matchLabels:
            .: {}
            f:custom-kubelet: {}
    manager: oc
    operation: Update
    time: "2020-08-11T06:17:18Z"
  - apiVersion: machineconfiguration.openshift.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:finalizers:
          .: {}
          v:"2291b9e1-6bbf-4ad8-982f-5d1c5285b88e": {}
      f:status:
        .: {}
        f:conditions: {}
    manager: machine-config-controller
    operation: Update
    time: "2020-08-11T06:17:19Z"
  name: worker-kubeconfig-fix
  resourceVersion: "96766"
  selfLink: /apis/machineconfiguration.openshift.io/v1/kubeletconfigs/worker-kubeconfig-fix
  uid: b3e6bcc7-51f2-4d2a-b898-2380f6ab14f9
spec:
  kubeletConfig:
    evictionPressureTransitionPeriod: 0s
    evictionSoft:
      memory.available: 90%
      nodefs.available: 90%
      nodefs.inodesFree: 90%
  machineConfigPoolSelector:
    matchLabels:
      custom-kubelet: small-pods
status:
  conditions:
  - lastTransitionTime: "2020-08-11T06:17:19Z"
    message: Success
    status: "True"
    type: Success

Comment 7 MinLi 2020-08-12 01:30:31 UTC

verified!

Comment 9 errata-xmlrpc 2020-08-17 20:05:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5.6 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3330