Bug 1853326

Description of problem:
Originally, we had an issue where podman segfaulted upon attempting to do a build from a remote image from a JFrog Artifactory repository like so:

# podman build --creds user:pass --tag me:test -f ./Dockerfile
STEP 1: FROM mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x58 pc=0x55e0f9f69f18]

Checking the goroutine at fault, I found this to be fixed in https://github.com/containers/buildah/pull/1960/commits/62b7fcef3d049191f16d55c61e169c799ebdb221, so to be sure of the resolution, I took the customer's version of podman, added the vendored commit, and had it rebuilt to ensure that was the fix.  Although it definitely fixed the segfault, I was expecting a MIME-type mismatch or something similar judging from the segfault, and as I had no core, I couldn't actually check the Content-Types sent.  When they retested, however, the error message this commit introduced produced the following:

# podman build --creds user:pass --tag me:test -f ./Dockerfile
STEP 1: FROM mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]
Error: error creating build container: error preparing image configuration: error converting image "containers-storage:[overlay@/var/lib/containers/storage+/var/run/containers/storage]mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]" from "application/vnd.docker.distribution.manifest.list.v2+json" to "application/vnd.docker.distribution.manifest.v2+json": Conversion of image manifest from application/vnd.docker.distribution.manifest.v2+json to application/vnd.docker.distribution.manifest.v2+json is not implemented

I added additional debugging in the form of https://github.com/containers/image/pull/201/commits/36b3e49b50ae9c28676fc26822b13b9ecfa39842 which shows that the manifest types in use are in fact as described; I can attach these if you'd like.

Note this only happens on build attempts with this image so far as I can tell.  Pulling or inspecting the image works fine, and if you delete it locally and pull it first, then attempt to build, it still fails:

# skopeo inspect --creds user:pass mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]
{
    "Name": "mydocker-registry.artifactory.example.com/ubi7/ubi",
    "Digest": "sha256:[SOMEHASH]",
    "RepoTags": [
        "7.6",
        "7.6-123",
        "7.6-177",
        "7.6-177.1561066496",
        "7.6-177.1561619828",
        "7.6-239",
        "7.6-73",
        "7.7",
        "7.7-140",
        "7.7-178",
        "7.7-214",
        "7.7-214.1575996166",
        "7.7-214.1580117713",
        "7.7-310",
        "7.7-310-source",
        "7.7-358",
        "7.7-358-source",
        "7.7-99",
        "7.8",
        "7.8-255",
        "7.8-255-source",
        "7.8-311",
        "7.8-311-source",
        "7.8-345",
        "7.8-345-source",
        "latest"
    ],
    "Created": "2020-05-11T17:22:52.084344Z",
    "DockerVersion": "1.13.1",
    "Labels": {
        "architecture": "x86_64",
        "build-date": "2020-05-11T17:22:15.219602",
        "com.redhat.build-host": "cpt-1008.osbs.prod.upshift.rdu2.redhat.com",
        "com.redhat.component": "ubi7-container",
        "com.redhat.license_terms": "https://www.redhat.com/en/about/red-hat-end-user-license-agreements#UBI",
        "description": "The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.",
        "distribution-scope": "public",
        "io.k8s.description": "The Universal Base Image is designed and engineered to be the base layer for all of your containerized applications, middleware and utilities. This base image is freely redistributable, but Red Hat only supports Red Hat technologies through subscriptions for Red Hat products. This image is maintained by Red Hat and updated regularly.",
        "io.k8s.display-name": "Red Hat Universal Base Image 7",
        "io.openshift.tags": "base rhel7",
        "name": "ubi7",
        "release": "311",
        "summary": "Provides the latest release of the Red Hat Universal Base Image 7.",
        "url": "https://access.redhat.com/containers/#/registry.access.redhat.com/ubi7/images/7.8-311",
        "vcs-ref": "c8670b8ad70b591aaaafec3922308cb8e013a354",
        "vcs-type": "git",
        "vendor": "Red Hat, Inc.",
        "version": "7.8"
    },
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:[SOMEHASH]"
    ],
    "Env": [
        "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
        "container=oci"
    ]
} 

# podman rmi -f -a
Untagged: mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]
Deleted: d36cb7ab60042e6687e221c9bfdc4b0c674e7753cff56f71bc3bd66e957598cc

# podman pull --creds user:pass mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]
Trying to pull mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]...
Getting image source signatures
Copying blob 82a8f4ea76cb done  
Copying blob a3ac36470b00 done  
Copying config d36cb7ab60 done  
Writing manifest to image destination
Storing signatures
d36cb7ab60042e6687e221c9bfdc4b0c674e7753cff56f71bc3bd66e957598cc

# podman build --creds user:pass --tag me:test -f ./Dockerfile
STEP 1: FROM mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]
Error: error creating build container: error preparing image configuration: error converting image "containers-storage:[overlay@/var/lib/containers/storage+/var/run/containers/storage]mydocker-registry.artifactory.example.com/ubi7/ubi@sha256:[SOMEHASH]" from "application/vnd.docker.distribution.manifest.list.v2+json" to "application/vnd.docker.distribution.manifest.v2+json": Conversion of image manifest from application/vnd.docker.distribution.manifest.v2+json to application/vnd.docker.distribution.manifest.v2+json is not implemented

I am at the moment at a loss how we are failing from "Conversion of image manifest from application/vnd.docker.distribution.manifest.v2+json to application/vnd.docker.distribution.manifest.v2+json is not implemented" but continuing to look into it.  I am assuming that, in addition to this patch, we added some other facility in a later version that isn't present and subsequently the one patch isn't enough.

Version-Release number of selected component (if applicable):
podman-1.6.4-18.el7_8 with above error-handling patch cherry-picked on top.

How reproducible:
Every time in customer environment

Steps to Reproduce:
Attempt to build 

Actual results:
Segfaults/Errors on building images

Expected results:
Image should build

Additional info:
I will have them test just a generally later version of podman, and am requesting a copy of the image in the interim.