Bug 1853622
| Summary: | Review Request: perl-Test-RandomResult - Test that results of a running code look random | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-RandomResult-0.001-1.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-07 07:01:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1853629 | ||
|
Description
Jitka Plesnikova
2020-07-03 11:26:16 UTC
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 06d948be8fbb4ed8854e70fc79cd50b9b3fb161e3feb6e3967c341ba572c1eae) is original. Ok.
Summary verified from lib/Test/RandomResult.pm. Ok.
FIX: Add a full stop to the description text.
License verified from README, LICENSE, Makefile.PL, and lib/Test/RandomResult.pm. Ok.
No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.
TODO: Unset AUTHOR_TESTING variable from the environment in a %check section before executing "make test".
All tests pass. Ok.
$ rpmlint perl-Test-RandomResult.spec ../SRPMS/perl-Test-RandomResult-0.001-1.fc33.src.rpm ../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm
drwxr-xr-x 2 root root 0 Jul 3 14:09 /usr/share/doc/perl-Test-RandomResult
-rw-r--r-- 1 root root 71 Jul 17 2019 /usr/share/doc/perl-Test-RandomResult/Changes
-rw-r--r-- 1 root root 2239 Jul 17 2019 /usr/share/doc/perl-Test-RandomResult/README
drwxr-xr-x 2 root root 0 Jul 3 14:09 /usr/share/licenses/perl-Test-RandomResult
-rw-r--r-- 1 root root 18367 Jul 17 2019 /usr/share/licenses/perl-Test-RandomResult/LICENSE
-rw-r--r-- 1 root root 2187 Jul 3 14:09 /usr/share/man/man3/Test::RandomResult.3pm.gz
drwxr-xr-x 2 root root 0 Jul 3 14:09 /usr/share/perl5/vendor_perl/Test
-rw-r--r-- 1 root root 5051 Jul 17 2019 /usr/share/perl5/vendor_perl/Test/RandomResult.pm
File layout ans permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.32.0)
1 perl(Exporter)
1 perl(strict)
1 perl(Test2::API)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Constrain 'perl(Exporter)' with >= 5.57.
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm | sort -f | uniq -c
1 perl(Test::RandomResult) = 0.001
1 perl-Test-RandomResult = 0.001-1.fc33
Binary provides are Ok.
$ resolvedeps f33-build ../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=46511820). Ok.
Otherwise the package is in line with Fedora and Perl packagaging guidelines.
Please correct the 'FIX' item, and consider fixing 'TODO' items before building this package.
Resolution: Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-RandomResult Thank you for the review and the repository. |