Bug 1853634
| Summary: | Review Request: perl-Color-ANSI-Util - Routines for dealing with ANSI colors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Color-ANSI-Util-0.164-1.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-07 16:55:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1853629 | ||
| Bug Blocks: | 1853571 | ||
|
Description
Jitka Plesnikova
2020-07-03 12:04:18 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 681c1c88d0d06e635d981482db855d2b8803b9a31e8de54e18912e76d1fdd062) is original. Ok.
Summary verified from lib/Color/ANSI/Util.pm. Ok.
Description verified. Ok.
License verified from README and lib/Color/ANSI/Util.pm. Ok.
No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.
AUTHOR_TESTING variable is unset before executing "make test". Ok.
$ rpmlint perl-Color-ANSI-Util.spec review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.src.rpm
perl-Color-ANSI-Util.noarch: W: spelling-error %description -l en_US ansifg -> ANSI
perl-Color-ANSI-Util.noarch: W: spelling-error %description -l en_US ansibg -> ANSI
perl-Color-ANSI-Util.src: W: spelling-error %description -l en_US ansifg -> ANSI
perl-Color-ANSI-Util.src: W: spelling-error %description -l en_US ansibg -> ANSI
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpm -q -lv -p review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm 12:37:20
drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/doc/perl-Color-ANSI-Util
-rw-r--r-- 1 root root 3200 Jun 9 11:01 /usr/share/doc/perl-Color-ANSI-Util/Changes
-rw-r--r-- 1 root root 8293 Jun 9 11:01 /usr/share/doc/perl-Color-ANSI-Util/README
drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/licenses/perl-Color-ANSI-Util
-rw-r--r-- 1 root root 18493 Jun 9 11:01 /usr/share/licenses/perl-Color-ANSI-Util/LICENSE
-rw-r--r-- 1 root root 3408 Jul 4 12:34 /usr/share/man/man3/Color::ANSI::Util.3pm.gz
drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/perl5/vendor_perl/Color
drwxr-xr-x 2 root root 0 Jul 4 12:34 /usr/share/perl5/vendor_perl/Color/ANSI
-rw-r--r-- 1 root root 24365 Jun 9 11:01 /usr/share/perl5/vendor_perl/Color/ANSI/Util.pm
File layout and permissions are Ok.
$ rpm -q --requires -p review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm | sort -f | uniq
perl(:MODULE_COMPAT_5.32.0)
perl(:VERSION) >= 5.10.1
perl(Color::RGB::Util) >= 0.600
perl(Exporter) >= 5.57
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p review-perl-Color-ANSI-Util/results/perl-Color-ANSI-Util-0.164-1.fc33.noarch.rpm | sort -f | uniq -c
1 perl(Color::ANSI::Util) = 0.164
1 perl-Color-ANSI-Util = 0.164-1.fc33
Binary provides are Ok.
The package builds in Fedora 33 (Mock). Ok.
The package is in line with Fedora and Perl packagaging guidelines.
Resolution: Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Color-ANSI-Util Thank you for the review and the repository. |