Bug 1853674
| Summary: | Review Request: perl-Module-Load-Util - Some utility routines related to module loading | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Module-Load-Util-0.003-1.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-07 17:37:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1853669 | ||
| Bug Blocks: | 1853571 | ||
|
Description
Jitka Plesnikova
2020-07-03 14:07:25 UTC
URL and Source addresses are Ok.
Source archive (SHA-256: 47a0e7c2ddbb70f4803de0a09a54f001de2e07a2c90e8feaa8536cafe7968e1a) is original. Ok.
Summary verified from lib/Module/Load/Util.pm. Ok.
Description verified. Ok.
License verified from README and lib/Module/Load/Util.pm. Ok.
No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.
AUTHOR_TESTING variable is unset before executing "make test". Ok.
$ rpmlint perl-Module-Load-Util.spec review-perl-Module-Load-Util/results/perl-Module-Load-Util-0.003-1.fc33.noarch.rpm review-perl-Module-Load-Util/results/perl-Module-Load-Util-0.003-1.fc33.src.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpm -q -lv -p review-perl-Module-Load-Util/results/perl-Module-Load-Util-0.003-1.fc33.noarch.rpm 13:21:42
drwxr-xr-x 2 root root 0 Jul 4 13:19 /usr/share/doc/perl-Module-Load-Util
-rw-r--r-- 1 root root 542 Jun 16 07:17 /usr/share/doc/perl-Module-Load-Util/Changes
-rw-r--r-- 1 root root 6068 Jun 16 07:17 /usr/share/doc/perl-Module-Load-Util/README
drwxr-xr-x 2 root root 0 Jul 4 13:19 /usr/share/licenses/perl-Module-Load-Util
-rw-r--r-- 1 root root 18367 Jun 16 07:17 /usr/share/licenses/perl-Module-Load-Util/LICENSE
-rw-r--r-- 1 root root 3104 Jul 4 13:19 /usr/share/man/man3/Module::Load::Util.3pm.gz
drwxr-xr-x 2 root root 0 Jul 4 13:19 /usr/share/perl5/vendor_perl/Module
drwxr-xr-x 2 root root 0 Jul 4 13:19 /usr/share/perl5/vendor_perl/Module/Load
-rw-r--r-- 1 root root 8958 Jun 16 07:17 /usr/share/perl5/vendor_perl/Module/Load/Util.pm
File layout ans permissions are Ok.
$ rpm -q --requires -p review-perl-Module-Load-Util/results/perl-Module-Load-Util-0.003-1.fc33.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.32.0)
1 perl(Exporter) >= 5.57
1 perl(Regexp::Pattern::Perl::Module)
1 perl(strict)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p review-perl-Module-Load-Util/results/perl-Module-Load-Util-0.003-1.fc33.noarch.rpm | sort -f | uniq -c
1 perl(Module::Load::Util) = 0.003
1 perl-Module-Load-Util = 0.003-1.fc33
Binary provides are Ok.
The package builds in Fedora 33 (Mock). Ok.
The package is in line with Fedora and Perl packagaging guidelines.
Resolution: Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Module-Load-Util Thank you for the review and the repository. |