Bug 1853700

Summary: condition too strict in pci plugin /proc/bus/pci/00 existence
Product: Red Hat Enterprise Linux 8 Reporter: Miroslav Hradílek <mhradile>
Component: sosAssignee: Pavel Moravec <pmoravec>
Status: CLOSED ERRATA QA Contact: Miroslav Hradílek <mhradile>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.3CC: agk, bmr, jhunsaker, kanderso, lmiksik, pghole, plambri, pmoravec, randalap, sbradley
Target Milestone: rcKeywords: Regression
Target Release: 8.3Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sos-3.9.1-5.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1853701 (view as bug list) Environment:
Last Closed: 2020-11-04 01:58:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1842946, 1853701    

Description Miroslav Hradílek 2020-07-03 15:01:14 UTC
Description of problem:

Commit
https://github.com/sosreport/sos/commit/1b70c61d882036e72449e0fca8dd11cb7eb72bcb

causes that lspci commands are not collected on machines without
/proc/bus/pci/00

I'm no PCI expert but it seams that there can still be useful information on machines with different directory structure under /proc/bus/pci/.

There was bug 238778 requesting the commands to be collected and preventing that might constitute a regression in this case.

Version-Release number of selected component (if applicable):
sos-3.9.1-4.el8.noarch (unreleased)

How reproducible:
100% on machine without /proc/bus/pci/00

Steps to Reproduce:
1. sosreport -o pci

Actual results:
Missing "lspci -nnvv" and "lspci -tv".

Expected results:
Collected "lspci -nnvv" and "lspci -tv".

Additional info:
# arch
aarch64

# tree  /proc/bus/pci
/proc/bus/pci
├── 0000:00
│   ├── 00.0
│   ├── 01.0
│   ├── 01.1
│   ├── 01.2
│   ├── 01.3
│   ├── 01.4
│   └── 01.5
├── 0000:01
│   └── 00.0
├── 0000:02
│   └── 00.0
├── 0000:03
│   └── 00.0
├── 0000:04
│   └── 00.0
├── 0000:05
│   └── 00.0
└── devices

Comment 1 Jake Hunsaker 2020-07-03 16:31:21 UTC
The fix has been merged into upstream master:

https://github.com/sosreport/sos/commit/1c87810faf65fa2c6165d917dd3cc51b3c90a969

Comment 2 Pavel Moravec 2020-07-03 18:24:49 UTC
This would be a regression if not fixed in 8.3, hence requesting an exception to 8.3.0.

Thanks for spotting it and fixing in upstream.

Comment 18 errata-xmlrpc 2020-11-04 01:58:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sos bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4534