Bug 1853960
Summary: | 5.7 kernel regression: unable to suspend, AER errors without pci=noaer | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Robert Hancock <hancockrwd> | ||||
Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 32 | CC: | acaringi, airlied, bskeggs, cks-rhbugzilla, hdegoede, ichavero, itamar, jarodwilson, jeremy, jglisse, john.j5live, jonathan, josef, kernel-maint, lgoncalv, linville, masami256, mchehab, mjg59, steved | ||||
Target Milestone: | --- | Keywords: | Patch, Regression | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | --- | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2020-08-08 02:13:47 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Robert Hancock
2020-07-06 00:18:28 UTC
It appears that the AER errors are related to the suspend failure, as suspend works if the pci=noaer option is added to the kernel command line. I am guessing that these errors occurring during the suspend process are causing the machine to immediately wake up again. Reported to LKML: https://lkml.org/lkml/2020/7/10/1267 As I posted on LKML, it seems that the issue may have been caused by an upstream change that went into the 5.7 stable series to enable PCIe ASPM on PCIe to PCI bridges: commit 66ff14e59e8a30690755b08bc3042359703fb07a Author: Kai-Heng Feng <kai.heng.feng> Date: Wed May 6 01:34:21 2020 +0800 PCI/ASPM: Allow ASPM on links to PCIe-to-PCI/PCI-X Bridges 7d715a6c1ae5 ("PCI: add PCI Express ASPM support") added the ability for Linux to enable ASPM, but for some undocumented reason, it didn't enable ASPM on links where the downstream component is a PCIe-to-PCI/PCI-X Bridge. Remove this exclusion so we can enable ASPM on these links. The Dell OptiPlex 7080 mentioned in the bugzilla has a TI XIO2001 PCIe-to-PCI Bridge. Enabling ASPM on the link leading to it allows the Intel SoC to enter deeper Package C-states, which is a significant power savings. [bhelgaas: commit log] Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=207571 Link: https://lore.kernel.org/r/20200505173423.26968-1-kai.heng.feng@canonical.com Signed-off-by: Kai-Heng Feng <kai.heng.feng> Signed-off-by: Bjorn Helgaas <bhelgaas> Reviewed-by: Mika Westerberg <mika.westerberg.com> Disabling ASPM manually on this ASMedia bridge device as well as the PCIe root port it is connected to seems to resolve the problem: setpci -s 00:1c.0 0x50.B=0x00 setpci -s 02:00.0 0x90.B=0x00 Patch submitted upstream: https://patchwork.ozlabs.org/project/linux-pci/patch/20200722021803.17958-1-hancockrwd@gmail.com/ Patch has been merged into mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b361663c5a40c8bc758b7f7f2239f7a192180e7c I have nominated it for stable kernels as well, as the previous patch that exposed the issue was added to stable. Fixed in build kernel-5.7.14-200.fc32: https://koji.fedoraproject.org/koji/buildinfo?buildID=1586714 |