Bug 1854098

Summary: NodeNetworkState on workers doesn't have "status" key due to nmstate-handler pod failure to run "nmstatectl show"
Product: Container Native Virtualization (CNV) Reporter: Yossi Segev <ysegev>
Component: NetworkingAssignee: Petr Horáček <phoracek>
Status: CLOSED ERRATA QA Contact: Yossi Segev <ysegev>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.4.0CC: cnv-qe-bugs, ellorent
Target Milestone: ---   
Target Release: 2.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubernetes-nmstate-handler-container-v2.6.0-8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-10 11:16:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
worker-nmstate-handler-snippet.log none

Description Yossi Segev 2020-07-06 12:05:50 UTC
Created attachment 1700019 [details]
worker-nmstate-handler-snippet.log

Description of problem:
On one of CNV QE's bare-metals (bm-rhel), there are 3 masters and 2 workers.
The nmstate-handler pods of both workers don't include "status" key.


Version-Release number of selected component (if applicable):
$ oc version
Client Version: 4.5.0-rc.1
Server Version: 4.5.0-rc.5
Kubernetes Version: v1.18.3+f291db1

CNV: 2.4.0

nmstate version: registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-kubernetes-nmstate-handler-rhel8@sha256:794345eb05f43c0c37e2e21b9bd10306051a6946d845ec1541ba78419a22d5fb


How reproducible:
Always


Steps to Reproduce:
1.
Once a new cluster is deployed on this BM machine - find which NNS belong to a worker:
[cnv-qe-jenkins@cnv-executor-bm-rhel ~]$ oc get nns 
NAME                                      AGE
cnv-qe-02.cnvqe.lab.eng.rdu2.redhat.com   4d3h
cnv-qe-03.cnvqe.lab.eng.rdu2.redhat.com   4d3h
cnv-qe-04.cnvqe.lab.eng.rdu2.redhat.com   4d3h
cnv-qe-05.cnvqe.lab.eng.rdu2.redhat.com   4d3h
cnv-qe-06.cnvqe.lab.eng.rdu2.redhat.com   4d3h
[cnv-qe-jenkins@cnv-executor-bm-rhel ~]$ oc get nodes
NAME                                      STATUS   ROLES    AGE   VERSION
cnv-qe-02.cnvqe.lab.eng.rdu2.redhat.com   Ready    worker   27d   v1.18.3+f291db1
cnv-qe-03.cnvqe.lab.eng.rdu2.redhat.com   Ready    worker   27d   v1.18.3+f291db1
cnv-qe-04.cnvqe.lab.eng.rdu2.redhat.com   Ready    master   27d   v1.18.3+f291db1
cnv-qe-05.cnvqe.lab.eng.rdu2.redhat.com   Ready    master   27d   v1.18.3+f291db1
cnv-qe-06.cnvqe.lab.eng.rdu2.redhat.com   Ready    master   27d   v1.18.3+f291db1
[cnv-qe-jenkins@cnv-executor-bm-rhel ~]$ 

2.
View the spec of one of the workers' NNS:
$ oc get nns cnv-qe-02.cnvqe.lab.eng.rdu2.redhat.com -o yaml


Actual results:
Output spec should include "status" key, e.g.:
status:
  currentState:
    dns-resolver:
      config:
...


Expected results:
<BUG> There's no "status" in the output spec.


Additional info:
The attached error (worker-nmstate-handler-snippet.log) appears in the nmstate-handler pod log of the worker.

Comment 1 Quique Llorente 2020-07-06 12:46:42 UTC
Can we retrive the nmstate version ? 

We can list the RPMs at containers with

oc exec -n nmstate nmstate-handler-[pod suffix] -- rpm -qa |grep nmstate

Comment 2 Quique Llorente 2020-07-06 12:51:00 UTC
Have check the container directly looks like we have the following

[root@322541f1c46b /]# rpm -qa |grep nmstate
python3-libnmstate-0.2.6-13.el8_2.noarch
nmstate-0.2.6-13.el8_2.noarch

Comment 3 Yossi Segev 2020-07-06 13:04:08 UTC
(In reply to Quique Llorente from comment #1)
> Can we retrieve the nmstate version ? 

We can't.
We used to be able to view plugins' versions via the CNAO deployment, but now all we see there is the sha value of the version of each plugin. AFAIR the shavalue can be mapped to the corresponding plugin version in brew.
I specified the sha of nmstate in the description above (sha256:794345eb05f43c0c37e2e21b9bd10306051a6946d845ec1541ba78419a22d5fb).

> 
> We can list the RPMs at containers with
> 
> oc exec -n nmstate nmstate-handler-[pod suffix] -- rpm -qa |grep nmstate

Comment 4 Quique Llorente 2020-07-06 13:48:30 UTC
After talking with nmstate team, looks like has being fixed at nmstate 0.3 but not 0.2 (the version at CNV 2.4) they are going to try to backport what is needed to their 0.2 version.


github issue tracking it https://github.com/nmstate/nmstate/issues/1187.

Comment 6 Petr Horáček 2020-09-03 12:11:02 UTC
2.5 is still on nmstate 0.2.

Comment 7 Yossi Segev 2020-12-20 15:07:15 UTC
Verified in version:
OCP 4.7.0
CNV 2.6.0
nmstate nmstate-0.3.4-15.el8_3.noarch

Repeated the same scenario as in the bug descriptions - "status" exists in the NNS spec.

Comment 10 errata-xmlrpc 2021-03-10 11:16:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 2.6.0 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0799