Bug 1854195

Summary: HTTP/2 backend support breaks websocket
Product: OpenShift Container Platform Reporter: Ben Bennett <bbennett>
Component: NetworkingAssignee: Andrew McDermott <amcdermo>
Networking sub component: router QA Contact: Hongan Li <hongli>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: amcdermo, aos-bugs, bbennett, elalance, hongli, jboxman, kwall, lmohanty, wking
Version: 4.4Keywords: Upgrades
Target Milestone: ---   
Target Release: 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1853711 Environment:
Last Closed: 2020-07-13 17:44:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1853711    
Bug Blocks: 1854814    

Comment 3 Hongan Li 2020-07-07 07:33:45 UTC
verified with 4.5.0-0.nightly-2020-07-07-021002 and the issue has been fixed.

1. HTTP/2 is disabled by default

$ oc -n openshift-ingress rsh router-default-85f9c9c76d-4z2ld
sh-4.2$ env | grep -i http2
ROUTER_DISABLE_HTTP2=true
sh-4.2$ grep server haproxy.config | grep "h2,"
sh-4.2$ 

2. HTTP/2 can be enabled by annotation
$ oc create -f ingresscontroller-test.yaml
$ oc -n openshift-ingress-operator annotate ingresscontroller/test ingress.operator.openshift.io/default-enable-http2=true
ingresscontroller.operator.openshift.io/test annotated

$ oc -n openshift-ingress rsh router-test-56d4649798-rbcgp
sh-4.2$ env | grep -i http2
ROUTER_DISABLE_HTTP2=false
sh-4.2$ grep server haproxy.config | grep "h2,"
<---snip--->
  server pod:console-5c4c7d4989-qth2g:console:10.129.0.48:8443 10.129.0.48:8443 cookie ad942682e6c544eb4eed168e233bc6da weight 256 ssl alpn h2,http/1.1 verifyhost console.openshift-console.svc verify required ca-file /var/run/configmaps/service-ca/service-ca.crt check inter 5000ms

Comment 4 errata-xmlrpc 2020-07-13 17:44:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409

Comment 5 W. Trevor King 2021-04-05 17:47:51 UTC
Removing UpgradeBlocker from this older bug, to remove it from the suspect queue described in [1].  If you feel like this bug still needs to be a suspect, please add keyword again.

[1]: https://github.com/openshift/enhancements/pull/475