Bug 1854238
| Summary: | Labeling and Confirmation Dialog for UI Elements start(on)/stop(off)/restart(reboot) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Alex Mayberry <amayberr> | ||||||
| Component: | pcs | Assignee: | Tomas Jelinek <tojeline> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> | ||||||
| Severity: | low | Docs Contact: | Steven J. Levine <slevine> | ||||||
| Priority: | medium | ||||||||
| Version: | 8.0 | CC: | cfeist, cluster-maint, idevat, mlisik, mmazoure, mpospisi, omular, slevine, tojeline | ||||||
| Target Milestone: | rc | Keywords: | Triaged | ||||||
| Target Release: | 8.5 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | pcs-0.10.8-2.el8 | Doc Type: | Bug Fix | ||||||
| Doc Text: |
Cause:
It is not clear that 'Restart' button in the node detail page reboots a cluster node.
Consequence:
Users may reboot a node thinking the button restarts merely cluster services. This causes unwanted downtime.
Fix:
Add tooltips to buttons 'Start', 'Stop', 'Node Restart' explaining effects of clicking the button. Add a confirmation dialog for 'Node Restart'.
Result:
It is clear what buttons do. An extra confirmation is required for rebooting a node.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-11-09 17:33:51 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1784362 [details]
proposed fix
Test:
* Display a cluster node page in web UI
* Hover over 'Start', 'Stop' and 'Node Restart' buttons. Notice an explanatory text being displayed in a tooltip.
* Click on 'Node Restart'. Confirmation is required to proceed and reboot a node.
Test: [root@r8-node-01 ~]# rpm -q pcs pcs-0.10.8-2.el8.x86_64 Action buttons on the cluster node page has explanatory text displayed in a tooltip: Start - Start cluster services on the node Stop - Stop cluster services on the node Node Restart - Reboot the node Node Restart action has a confirmation dialog with a text: This will reboot node 'r8-node-01'. Do you want to continue? BEFORE: ======= [root@virt-267 ~]# rpm -q pcs pcs-0.10.8-1.el8.x86_64 1. Open web ui: https://virt-267.cluster-qe.lab.eng.brq.redhat.com:2224/login and log in 2. Add cluster to the web ui (create new or add existing) 3. Click on the newly added cluster 4. For an each node at Node tab, there are options "Start", "Stop", "Restart" and others. There is no explanatory text while hovering over the the buttons and "Restart" might be confused for services restart. The node is instantly restarted without any confirmation, when clicking on "Restart". AFTER: ====== [root@virt-290 ~]# rpm -q pcs pcs-0.10.8-3.el8.x86_64 1. Open web ui: https://virt-290.cluster-qe.lab.eng.brq.redhat.com:2224/login#/nodes/virt-267 and log in 2. Add cluster to the web ui (create new or add existing) 3. Click on the newly added cluster 4. For an each node at Node tab, there are options "Start", "Stop", "Node Restart" and others. - The button is renamed from "Restart" to more convenient "Node Restart". - There is an explanatory text while hovering over the buttons - Start - "Start cluster services on the node" - Stop - "Stop cluster services on the node" - Node Restart - "Reboot the node" - There is a confirmation dialog when clicking "Node Restart" - "This will reboot node 'virt-291'. Do you want to continue?". - Nothing will happen when clicking on "Cancel", the node is rebooted after clicking "OK" General functionality of the web UI was checked by regression test suite within bz1886342. Marking as VERIFIED in pcs-0.10.8-3.el8 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Low: pcs security, bug fix, and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:4142 |
Created attachment 1700076 [details] ui-reference-image Description of problem: I would like to request that stop/start/restart be more clearly labeled, and possibly include a confirmation warning/dialog. While attempting to deploy the cluster software, and do the initial setup, I elected to use the web UI. I made the mistake of interpreting 'restart' as a service restart, vs. hardware/OS actions of shutdown/reboot. I was prepared to accept that this was purely a *me* problem, but I have shown the screenshot to several of my peers, and most of them either acknowledge the potential, or outright admit they would most likely have interpreted this the same way I did had I not pointed this out to them ahead of time. The presence of these buttons within the context of 'node' does offer a clue by way of context, but in my case I interpreted this as stopping/starting services on those nodes, vs. all clusters managed by the UI. A warning message that this will reboot the server might be a bit overkill, but on some of the very largest systems we work with, this can result in one or more hours of recovery time waiting for systems gracefully exit during the shutdown portion, and to boot back up and all services and software to come back online. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Open the Web UI 2. Click the 'restart' button in the nodes section 3. Wait for your system to finish rebooting Actual results: Expected results: I had expected `systemctl restart` on services, without disturbing the OS. Additional info: