Bug 1854257

Summary:	[machines] The VM can only be fold/unfold by clicking the arrow before the name of the vm
Product:	Red Hat Enterprise Linux 8	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-appstream	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.3	CC:	mpitt, wshi, ymao, yunyang
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	8.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 03:09:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2020-07-07 00:45:39 UTC

Description of problem: 
The VM can only be fold/unfold by clicking the arrow before the name of the vm

Version-Release number of selected component (if applicable):
cockpit-machines-222.1-1.el8.noarch
libvirt-dbus-1.3.0-2.module+el8.3.0+6423+e4cb6418.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a VM
2. Click the arrow before the name of the vm to fold/unfold it
3. Click the row of the name of the vm to fold/unfold it


Actual results:
In step 3, the vm can not to be fold/unfold like before.

Expected results:
In step 3, the vm should able to be fold/unfold like before.

Additional info:
Did we make this change intended ? But I think it's more convenient to fold/unfold the vm by clicking the row.
By the way, we can still fold/unfold by clicking the row on  storage pool page, so I think they should be consistent.

Comment 1 Katerina Koukiou 2020-07-21 11:38:58 UTC

The tables should only expand when clicking on the toggle button, this is following the new design from Patternfly 4.
https://www.patternfly.org/v4/documentation/react/components/table#collapsible

I ported the Storage Pools and Networks tables to the new design, so now these two are consistent in matters of behavior with the VM one.

https://github.com/cockpit-project/cockpit/pull/14376

Relevant commits:
commit cf114780928e46c1e4b12ce1a5385fc65ba5f792
Author: Katerina Koukiou <kkoukiou>
Date:   Mon Jul 20 12:30:32 2020 +0200

    machines: Port Network List to ListingTable (PF4)
    
commit 263955e9db11396828d5a5d00fd7f83e6fe0c3ac
Author: Katerina Koukiou <kkoukiou>
Date:   Mon Jul 20 12:30:32 2020 +0200

    machines: Port StoragePool List to ListingTable (PF4)

Comment 4 Xianghua Chen 2020-07-31 02:57:52 UTC

Verified with package:
cockpit-machines-224-1.el8.noarch

Step:
1. Prepare a VM
2. Check Storage Pools and Networks tables and vms page, click the arrow before the name to fold/unfold them.


All consistent, so veyified.

Comment 7 errata-xmlrpc 2020-11-04 03:09:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-appstream bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4705