Bug 1854318

Summary: CNV 2.3 doc - NodeNetworkConfigurationPolicy: False forcing of user to set a static IP address
Product: Container Native Virtualization (CNV) Reporter: Yossi Segev <ysegev>
Component: DocumentationAssignee: Shikha Jhala <sjhala>
Status: CLOSED CURRENTRELEASE QA Contact: Yossi Segev <ysegev>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.3.0CC: cnv-qe-bugs, danken, ncredi, sjhala
Target Milestone: ---   
Target Release: 2.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-31 13:39:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yossi Segev 2020-07-07 07:43:18 UTC 
Document URL: 
https://docs.openshift.com/container-platform/4.4/cnv/cnv_node_network/cnv-updating-node-network-config.html#cnv-example-bridge-nncp_cnv-updating-node-network-config


Section Number and Name: 
Example: Linux bridge interface NodeNetworkConfigurationPolicy - comment #8


Describe the issue: 
Comment #8 says "Optional. If you do not use dhcp you must specify static IP address for the interface."
This is not true. Setting a static IP address is not mandatory.
The interface can exist and operate without an IP address.


Suggestions for improvement: 
Either remove this comment entirely, or replace it with something in the spirit of "Optional. If you do not use dhcp, you can either set a static IP, or leave the interface without an IP address at all."


Additional information:
Comment 1 Shikha Jhala 2020-07-20 16:43:19 UTC 
@Yossi Segev This PR is ready for SME review:

PR: https://github.com/openshift/openshift-docs/pull/23951

Preview Build: https://bz-1854318--ocpdocs.netlify.app/openshift-enterprise/latest/virt/node_network/virt-updating-node-network-config.html#virt-example-bridge-nncp_virt-updating-node-network-config
Comment 2 Yossi Segev 2020-07-20 17:03:42 UTC 
I reviewed and added a comment in the PR.
Comment 3 Shikha Jhala 2020-07-21 15:36:52 UTC 
@Nelly, does anyone else need to review this or can this bug be moved to Verified based on Yossi's ack?

PR: https://github.com/openshift/openshift-docs/pull/23951
Comment 6 Nelly Credi 2020-07-21 17:54:19 UTC 
@Yossi please mark it as VERIFIED if you are happy with it
Comment 9 Yossi Segev 2020-07-22 08:07:54 UTC 
Very well then.
Verified.
Comment 10 Shikha Jhala 2020-07-23 01:37:37 UTC 
The PR for this bug fix is now merged: https://github.com/openshift/openshift-docs/pull/23951
Comment 11 Shikha Jhala 2020-07-31 13:39:58 UTC 
Closing out this bug. Fix is now published in the customer-facing documentation: https://docs.openshift.com/container-platform/4.5/virt/node_network/virt-updating-node-network-config.html#virt-example-bridge-nncp_virt-updating-node-network-config