Bug 1854596

Summary:	Updating terraform plugin SDK breaks azure
Product:	OpenShift Container Platform	Reporter:	John Hixson <jhixson>
Component:	Installer	Assignee:	John Hixson <jhixson>
Installer sub component:	openshift-installer	QA Contact:	Etienne Simard <esimard>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	adahiya, ebenahar, esimard, madam, mbukatov, ocs-bugs
Version:	4.6	Keywords:	UpcomingSprint
Target Milestone:	---
Target Release:	4.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-27 16:12:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description John Hixson 2020-07-07 18:13:18 UTC

Description of problem (please be detailed as possible and provide log
snippests):

The AWS terraform provider was recently updated to v2.67.0 in PR https://github.com/openshift/installer/pull/3837to fix bug https://bugzilla.redhat.com/show_bug.cgi?id=1844320, which in turn required the terraform plugin SDK to be updated to v1.14.0, which ended up causing the Azure terraform provider to have some internal conflicts.

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?

Yes, Azure installation is no longer possible.

Is there any workaround available to the best of your knowledge?

No.

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?

Can this issue reproducible?

Yes.

Steps to Reproduce:
1. openshift-install create cluster
2. Azure + normal options
3. Profit!

Actual results:

level=error
level=error msg="Error: Internal validation of the provider failed! This is always a bug"
level=error msg="with the provider itself, and not a user issue. Please report"
level=error msg="this bug:"
level=error
level=error msg="3 errors occurred:"
level=error msg="\t* resource azurerm_key_vault_certificate: ConflictsWith: days_before_expiry configuration block reference (certificate_policy.0.lifetime_action.0.trigger.0.lifetime_percentage) can only be used with TypeList and MaxItems: 1 configuration blocks"
level=error msg="\t* resource azurerm_virtual_machine_scale_set: ConflictsWith: managed_disk_type configuration block reference (storage_profile_os_disk.vhd_containers) can only be used with TypeList and MaxItems: 1 configuration blocks"
level=error

Expected results:

A successful installation.

Additional info:

https://github.com/terraform-providers/terraform-provider-azurerm/commit/68a2f63372ddc2af2cddcedcd762caa59e5dead9 addresses the updated SDK problem.

Comment 3 John Hixson 2020-07-07 18:34:53 UTC

PR: https://github.com/openshift/installer/pull/3852

Comment 6 John Hixson 2020-07-10 03:47:02 UTC

The PR for this has merged.

Comment 9 Etienne Simard 2020-07-10 16:36:13 UTC

Verified with: 4.6.0-0.nightly-2020-07-10-092830

Installation successful and no apparent issue discovered.

Comment 11 errata-xmlrpc 2020-10-27 16:12:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196