Bug 1854892

+++ This bug was initially created as a clone of Bug #1849386 +++

Description of problem:

There are two ways of specifying interface names for a pppoe connection
to be started on an ethernet interface I will hereafter refer to as the old
and the new way.

The old one was (as saved in a .nmconnection file):

[connection]
id=adsl-internet
type=pppoe
interface-name=enp5s0

and the new one is:

[connection]
id=adsl-internet
type=pppoe
interface-name=ppp0
[pppoe]
parent=enp5s0

The old way is working fine for me, but it has a drawback that it seems to be
impossible to have an IP address and running pppoe on the same interface
at the same time. AFAIK that was the reason for introducing the new way.

When I use the new configuration (not changing anything else, only
the connection.interface-name and pppoe.parent as shown above), the pppoe connection
is established, but immediately terminated. No other retries are attempted. Bringing the
connection up manually with "nmcli conn up ..." succeeds though, but manual connection
maintainance is not a viable option.

The log contains this error: "assertion '<dropped>' failed":

NetworkManager[15807]: PAP authentication succeeded
NetworkManager[15807]: peer from calling number 7C:AD:XX:XX:XX:XX authorized
pppd[15807]: peer from calling number 7C:AD:XX:XX:XX:XX authorized
pppd[15807]: local  IP address 212.XX.XX.XX
pppd[15807]: nm-ppp-plugin: status 9 / phase 'running'
NetworkManager[15807]: local  IP address 212.XX.XX.XX
NetworkManager[15807]: remote IP address 84.XX.XX.XX
NetworkManager[15807]: primary   DNS address 195.XX.XX.XX
NetworkManager[15807]: secondary DNS address 195.XX.XX.XX
NetworkManager[15773]: ((src/devices/nm-device.c:1441)): assertion '<dropped>' failed
NetworkManager[15773]: <info>  [1592723907.0471] device (ppp0): state change: config -> failed (reason 'ip-config-unavailable', sys-iface-state: 'managed')
NetworkManager[15773]: <info>  [1592723907.0477] manager: NetworkManager state is now CONNECTED_LOCAL
NetworkManager[15773]: <warn>  [1592723907.0577] device (ppp0): Activation: failed for connection 'adsl-internet'

More lines of the log are in the attached file.


Version-Release number of selected component (if applicable):

NetworkManager-1.22.14-1.fc32.x86_64
NetworkManager-ppp-1.22.14-1.fc32.x86_64

How reproducible:
always

Steps to Reproduce:
1. Configure the NetworkManager with an Ethernet interface and a pppoe interface using the Ethernet as its parent;
2. systemctl restart NetworkManager

Actual results:
Ethernet up), pppoe down

Expected results:
Ethernet up, pppoe also up

Additional info:
I will add my configuration files or other information if needed.

--- Additional comment from Beniamino Galvani on 2020-07-03 21:47:53 CEST ---

Upstream merge request:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/564

--- Additional comment from Vlado Potisk on 2020-07-04 08:45:57 CEST ---

I read the desciption of the linked proposed patch. After changing the interface name from 'ppp0' to other string it works. I think you have found the problem's cause. Thank you.