Bug 1854957

Summary: The in-page edit labels link is not hidden when labels are read-only
Product: OpenShift Container Platform Reporter: Samuel Padgett <spadgett>
Component: Management ConsoleAssignee: Samuel Padgett <spadgett>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.6CC: aos-bugs, jokerman
Target Milestone: ---   
Target Release: 4.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Version: 4.6.0-0.nightly-2020-07-07-233934 Cluster ID: de31dbbc-4e97-419b-bf47-6e5f19ab8781 Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:79.0) Gecko/20100101 Firefox/79.0
Last Closed: 2020-10-27 16:13:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Verification screenshot - normal user
none
Verification screenshot - admin user none

Description Samuel Padgett 2020-07-08 13:31:05 UTC
We have no RBAC check for the in-page labels edit link. The action is hidden in the Actions menu, but it's not hidden for users who do not have edit access to the resource (such as users with the `view` role in a namespace).

We also show edit labels for projects, but labels aren't editable for projects.

Comment 4 XiaochuanWang 2020-07-13 06:05:17 UTC
Created attachment 1700765 [details]
Verification screenshot - normal user

Comment 5 XiaochuanWang 2020-07-13 06:06:19 UTC
Created attachment 1700766 [details]
Verification screenshot - admin user

Comment 6 XiaochuanWang 2020-07-13 06:08:12 UTC
As attached screenshots, Action button is hidden for normal user, Label editor is hidden for both admin and normal user on Project detail page. This is as expected from PR.
Verified on 4.6.0-0.nightly-2020-07-12-204440

Comment 8 errata-xmlrpc 2020-10-27 16:13:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6 GA Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4196