Bug 1855377

Summary: [CNV&RHV] Add-Disk operation failed to complete.
Product: Red Hat Enterprise Virtualization Manager Reporter: Pavol Brilla <pbrilla>
Component: ovirt-engineAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED ERRATA QA Contact: Pavol Brilla <pbrilla>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4.0CC: ahadas, asocha, bzlotnik, dfodor, michal.skrivanek, pelauter, tnisan
Target Milestone: ovirt-4.4.2Keywords: ZStream
Target Release: 4.4.2   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: ovirt-engine-4.4.2.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-09-23 16:11:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Pavol Brilla 2020-07-09 17:30:39 UTC 
Description of problem:
Add-Disk operation failed to complete. - was thrown in rhev-m after refresh of ocp virtualization cluster ( I was adding new vm and template inside ocp to start tests )

Version-Release number of selected component (if applicable):
4.4.1.5-0.17.el8ev

How reproducible:
100

Steps to Reproduce:
1. add new provider of ocp virtualization to rhevm
2. create new vm/  template inside ocp
3. check refresh of vm/templates inside rhevm - you will error message

Actual results:
I got error message inside rhevm about disk

Expected results:
information should be obtained without errors

Additional info:
will attach log in comment
Comment 1 Pavol Brilla 2020-07-09 17:33:56 UTC 
Created attachment 1700475 [details]
engine.log
Comment 2 Michal Skrivanek 2020-07-10 04:55:19 UTC 
possibly related to Benny's I329c4d7d2fc7322e4165acaaa678c5b553c15e01
Comment 3 Pavol Brilla 2020-07-10 09:51:42 UTC 
Possibly related to BZ#1854488
Comment 4 Pavol Brilla 2020-07-10 09:52:18 UTC 
Possibly related to BZ#1854488
Comment 5 Benny Zlotnik 2020-07-12 08:21:46 UTC 
(In reply to Michal Skrivanek from comment #2)
> possibly related to Benny's I329c4d7d2fc7322e4165acaaa678c5b553c15e01
Could be, though it seems like it has the same flow as regular disk image so it "should" work. But I don't see the creation itself, nor vdsm logs.
Is talayan-pytest-8gw99-worker-rgnr5 a vdsm host?
Pavol, can you provide the full logs?
Comment 6 Pavol Brilla 2020-07-24 13:11:42 UTC 
No it is not - talayan-pytest-8gw99-worker-rgnr5 is OCP worker talayan-pytest-8gw99-worker-rgnr5

From my point  this is duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1845396 <- process was same for both bugs - to create OCP VM in RHV - now there is code to block creation of diskless ocp vm, so I stop seeing this errorRHV
Comment 7 Benny Zlotnik 2020-07-28 10:02:35 UTC 
After discussing this, the callback was not supposed to run for CNV disks (and there was code to prevent it), but it did even before my patch because the disk type was overridden. I posted a fix to avoid running some of the code that is relevant only for regular images so no callback is run, it should also shave a few seconds off the operation
Comment 12 Pavol Brilla 2020-08-26 17:28:55 UTC 
Software Version:4.4.2.2-0.3.el8ev

Aug 26, 2020, 7:25:11 PM	
The disk 'example-disk-claim' was successfully added.

No errors on ocp pvcs
Comment 16 errata-xmlrpc 2020-09-23 16:11:10 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat Virtualization security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3807
Comment 18 Red Hat Bugzilla 2023-09-15 01:30:02 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 365 days