Bug 1855441

Created attachment 1700902 [details]
Update to minetest 5.3.0 and split data package

I maintain a copr build with some changes in the minetest packages and since minetest 5.3.0 has been released, it's maybe a good idea to propose those changes for the Fedora package.

So, here is my proposal: on it's own, the current minetest-server package is not functional because it lacks some data. It works only if you install it alongside the main minetest package.
So, I propose to extract the common data out of the main package and release it as a separate package that both minetest and minetest-server depends on.
I've also split out the minetest-game data as a new optional package as that one is not mandatory (you can install other minetest games mod). I've kept the current way of building with merged sources, but probably minetest-game could be build it's own, from another srpm.

Thanks for the contribution,  Olivier Samyn

As Minetest community keeps releasing the engine and the -game with the same version number, I'd prefer having one source rpm for them. Because it is only one update you need to do on each new release.

But splitting data from the mintest subpackage definitely makes sense. I'll try to apply your patch this week.

Let me know also if you'd like to have a co-maintainer rights for the package.

Keeping the game data in the same source srpm makes sense also, as it's the way of working of the upstream project. That's why I changed the spec to use the same version tag to refer to both archives.

As I revived my minetest server, and I expect to also work a bit on some input problems, I'll definitely be glad to help maintaining that package. I'm not part of the packages maintainers, but would be happy of some sponsor.

I've create a PR today https://src.fedoraproject.org/rpms/minetest/pull-request/6


But the build fails on aarch64 architecture with
 
----
In function 'memcpy',
    inlined from 'H_ns' at /builddir/build/BUILD/minetest-5.3.0/src/util/srp.cpp:432:8,
    inlined from 'calculate_x' at /builddir/build/BUILD/minetest-5.3.0/src/util/srp.cpp:455:13:
/usr/include/bits/string_fortified.h:34:33: warning: '__builtin_memcpy' reading 4294967295 bytes from a region of size 64 [-Wstringop-overflow=]
   34 |   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
      |                                 ^
/tmp/minetest.yDh9nn.ltrans32.ltrans.o: in function `TextDrawer::TextDrawer(wchar_t const*, Client*, irr::gui::IGUIEnvironment*, ISimpleTextureSource*)':
/builddir/build/BUILD/minetest-5.3.0/src/irrlicht_changes/irrUString.h:1664:(.text+0x813c): relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against `.LC40'
collect2: error: ld returned 1 exit status
----

https://koji.fedoraproject.org/koji/taskinfo?taskID=47885642

Unfortunately I did not activated aarch64 on my copr, I suppose I would have found that error. 

If you need help I can try to debug that in the coming days.

FEDORA-2020-66d7371d23 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-66d7371d23

It seems that aarch64 failure is connected to the LTO issues in current rawhide. Disabling LTO fixes the build.

Thus I have pushed a disable-LTO patch for master Rawhide, while pushed just the regular 5.3.0 update to F32.

Please take a look at the update and set karma.

And thanks again for the patch, Olivier!

FEDORA-2020-66d7371d23 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-66d7371d23`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-66d7371d23

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2020-66d7371d23 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.