Bug 1856603

Summary: Change man lvmthin to not say that the thin pool and thin lv will be lost upon unsuccessful repair
Product: Red Hat Enterprise Linux 8 Reporter: nikhil kshirsagar <nkshirsa>
Component: lvm2Assignee: Zdenek Kabelac <zkabelac>
lvm2 sub component: Thin Provisioning QA Contact: cluster-qe <cluster-qe>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: agk, cmackows, cmarthal, heinzm, jbrassow, msnitzer, pasik, prajnoha, thornber, zkabelac
Version: 8.2Keywords: Triaged
Target Milestone: rc   
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lvm2-2.03.12-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 19:45:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description nikhil kshirsagar 2020-07-14 03:53:31 UTC
Description of problem:
The lvmthin man page currently says

   Metadata check and repair

       If thin pool metadata is damaged, it may be repairable.  Checking and repairing thin pool metadata is analagous to running fsck/repair on a file system.
...

       Command to repair a thin pool:
       lvconvert --repair VG/ThinPoolLV

       Repair performs the following steps:
...

       If the repair does not work, the thin pool LV and its thin LVs are lost.


Can we change the wording to suggest that the meta0 will contain the original damaged metadata and that can be used for possible recovery, if the lvconvert --repair fails to automatically repair metadata?

Customer read the line saying that if repair doesnt work, the thin pool is lost, and they are reluctant to run lvconvert --repair

Comment 3 Zdenek Kabelac 2021-02-01 15:20:06 UTC
Pushed this upstream change:

https://www.redhat.com/archives/lvm-devel/2021-February/msg00000.html

giving some more details about repair steps.

Comment 6 Corey Marthaler 2021-06-01 19:10:54 UTC
Marking Verified:Tested in the latest lvm rpms.

kernel-4.18.0-305.7.el8.kpq1    BUILT: Mon May 17 12:55:07 CDT 2021
lvm2-2.03.12-2.el8    BUILT: Tue Jun  1 06:55:37 CDT 2021
lvm2-libs-2.03.12-2.el8    BUILT: Tue Jun  1 06:55:37 CDT 2021
device-mapper-1.02.177-2.el8    BUILT: Tue Jun  1 06:55:37 CDT 2021
device-mapper-libs-1.02.177-2.el8    BUILT: Tue Jun  1 06:55:37 CDT 2021


 Manual page lvmthin(7)
       If the repair works, the thin pool LV and its thin LVs can be activated.  User should manually check if repaired thin pool kernel metadata has all data for all lvm2 known LVs by individual
       activation of every thin LV. When all works, user should continue with fsck of all filesystems present on these volumes.  Once the thin pool is considered fully functional user may  remove
       ThinPoolLV_metaN  (the LV containing the damaged thin pool metadata) for possible space reuse.  For a better performance it may be useful to pvmove the new repaired metadata LV (written to
       previous pmspare volume) to a faster PV, e.g. SSD.

       If the repair operation fails, the thin pool LV and its thin LVs are not accessible and it may be necessary to restore their content from a backup.  In such case the content of  unmodified
       original damaged ThinPoolLV_metaN volume can be used by your support for more advanced recovery methods.

Comment 12 errata-xmlrpc 2021-11-09 19:45:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (lvm2 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4431