Bug 1857491

Summary: Need some whitespace between two sentences of a container warning message.
Product: Red Hat Enterprise Linux 8 Reporter: John Sefler <jsefler>
Component: subscription-managerAssignee: candlepin-bugs
Status: CLOSED ERRATA QA Contact: Red Hat subscription-manager QE Team <rhsm-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: arpandey, jhnidek, redakkan
Target Milestone: rcKeywords: EasyFix, Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: subscription-manager-1.28.15-1.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 19:37:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John Sefler 2020-07-16 01:45:20 UTC
Description of problem:
When attempting to run syspurpose within a running container, the following WARNING message is printed.  Notice the grammar.  White space is needed between the sentences.  A newline character would be best.

WARNING: Setting syspurpose in containers has no effect.Please run syspurpose on the host.


Version-Release number of selected component (if applicable):
[root@kvm-04-guest02 ~]# rpm -q python3-syspurpose
python3-syspurpose-1.27.9-1.el8.x86_64


How reproducible:


Steps to Reproduce:
[root@d686d25831f3 /]# syspurpose set-role "Red Hat Enterprise Linux Server"
WARNING: Setting syspurpose in containers has no effect.Please run syspurpose on the host.

role set to "Red Hat Enterprise Linux Server".
[root@d686d25831f3 /]#


Actual results:
WARNING: Setting syspurpose in containers has no effect.Please run syspurpose on the host.


Expected results:
WARNING: Setting syspurpose in containers has no effect.
Please run syspurpose on the host.


Additional info:

The offending string is located here...
[root@kvm-04-guest02 ~]# grep WARNING /usr/lib/python3.6/site-packages/syspurpose/cli.py -A2
        print(_("WARNING: Setting syspurpose in containers has no effect."
              "Please run syspurpose on the host.\n"))

Comment 4 Archana Pandey 2021-04-29 10:49:09 UTC
pre-verifying on development compose with subscription-manager: 1.28.16-1.el8:

 Beaker Test information:
                         HOSTNAME=kvm-05-guest24.hv2.lab.eng.bos.redhat.com
                            JOBID=5322348
                         RECIPEID=9915728
                    RESULT_SERVER=
                           DISTRO=RHEL-8.5.0-20210428.d.3
                     ARCHITECTURE=x86_64


[root@kvm-05-guest24 ~]# subscription-manager version
server type: This system is currently not registered.
subscription management server: 3.2.16-1
subscription management rules: 5.41
subscription-manager: 1.28.16-1.el8

[root@kvm-05-guest24 ~]# rpm -qa --changelog subscription-manager | grep 1857491
- 1857491: Add newline character to split a message into 2 lines
- 1857491: Add newline character to split a message into 2 lines
[root@kvm-05-guest24 ~]# 

verifying change in code base:
https://github.com/candlepin/subscription-manager/pull/2482/files#diff-17878a7c310205347735ba9f4d5ec2318c6a49edffa3e050af1218effd2e1766L348-R348

behavior will be validated once rhel8 container with fix is available

based on above observation moving to Verified:Tested

Comment 5 Archana Pandey 2021-04-30 11:36:09 UTC
Extending Comment 4 to provide more information on verification of fix inside container

Manually installing/upgrading subscription-manager package inside container and verifying

[root@80d77840a4d8 ~]# rpm -qa subscription-manager
subscription-manager-1.28.16-1.el8.x86_64
[root@80d77840a4d8 ~]# 
[root@80d77840a4d8 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux release 8.5 Beta (Ootpa)
[root@80d77840a4d8 ~]# 
[root@80d77840a4d8 ~]# syspurpose set-role "Red Hat Enterprise Linux Server"
WARNING: Setting syspurpose in containers has no effect.
Please run syspurpose on the host.  <<<<  notice the added newline character here

The 'syspurpose' command is deprecated and will be removed in a future major release. Please use the 'subscription-manager syspurpose' command going forward.                                                     
role set to "Red Hat Enterprise Linux Server".
[root@80d77840a4d8 ~]# 

Verified : As required newline character has been added in warning message

Comment 9 Rehana 2021-05-17 11:24:34 UTC
Reproducer : 

# syspurpose set-role "Red Hat Enterprise Linux Server"
WARNING: Setting syspurpose in containers has no effect.Please run syspurpose on the host.

role set to "Red Hat Enterprise Linux Server".

# rpm -qa subscription-manager
subscription-manager-1.28.13-2.el8.x86_64

Verifying on : 

manually updated the package version to : 
subscription-manager-1.28.16-1

# rpm -q --changelog subscription-manager | grep 1857491
- 1857491: Add newline character to split a message into 2 lines
- 1857491: Add newline character to split a message into 2 lines


# syspurpose set-role "Red Hat Enterprise Linux Server"
WARNING: Setting syspurpose in containers has no effect.
Please run syspurpose on the host.

The 'syspurpose' command is deprecated and will be removed in a future major release. Please use the 'subscription-manager syspurpose' command going forward.
role set to "Red Hat Enterprise Linux Server".

^^ As requested a newline has been added. 
moving the bug to Verified!!

Comment 12 errata-xmlrpc 2021-11-09 19:37:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (subscription-manager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4390