Bug 1857595

Summary: CInderLib integration isn't support in ovirt-ansible-hosted-engine-setup
Product: [oVirt] ovirt-engine Reporter: Shir Fishbain <sfishbai>
Component: Backup-Restore.EngineAssignee: Yedidyah Bar David <didi>
Status: CLOSED CURRENTRELEASE QA Contact: Shir Fishbain <sfishbai>
Severity: medium Docs Contact:
Priority: low    
Version: 4.4.1.10CC: bugs, didi, emarcus, michal.skrivanek, pelauter, stirabos
Target Milestone: ovirt-4.4.4Keywords: Reopened
Target Release: ---Flags: pm-rhel: ovirt-4.4+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-01-12 16:23:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine_log
none
setup.log none

Description Shir Fishbain 2020-07-16 08:32:50 UTC
Description of problem:
As a part of the plan to run the CinderLib integration flow for backup and restore from 4.3 to 4.4 with RHVH hosts, find that we have never installed CinderLib as part of the hosted engine deploy. 
We can see it also in github : https://github.com/oVirt/ovirt-ansible-hosted-engine-setup there is nothing about CinderLib there.

Version-Release number of selected component (if applicable):
ovirt-engine-4.3.11.2-0.1.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Running manually the "engine-setup --reconfigure-optional-components" on  hosted engine environment with RHVH hosts.
2. In the engine-setup : 
          Set up Cinderlib integration
          (Currently in tech preview)
          (Yes, No) [No]: yes

Actual results:
[ INFO  ] Checking for product updates...
[ INFO  ] No product updates found
There is nothing about CinderLib in ovirt-ansible-hosted-engine-setup .
The "ovirt_cinderlib ovirt_cinderlib" lines are missing in PostgreSQL Client Authentication Configuration File. (less /var/lib/pgsql/data/pg_hba.conf)

Expected results:
Get the support in ovirt-ansible-hosted-engine-setup for completed successfully the rest of the CinderLib integration flow for backup and restore from 4.3 to 4.4 with RHVH hosts.

Additional info:

Comment 1 Shir Fishbain 2020-07-16 08:36:49 UTC
Created attachment 1701348 [details]
engine_log

Comment 2 Shir Fishbain 2020-07-16 09:02:04 UTC
This bug blocks the CinderLib integration on RHVH in both 4.3 and 4.4.

I started to test the Migration path from 4.3 -> 4.4 on RHVH which includes:
* 4.3 RHVH CinderLib integration  => this is the current phase where the test blocked by the issue in the description below.
* 4.3 Engine-backup (4.3) including CinderLib data/SDs/VMs/Disk 
* Reprovision RHVH to 4.4
* 4.4 Engine restore 
* 4.4 Check all CinderLib data/SD's/VMs/Disks are there fully functional.

The hosted-engine-setup should add the option to activate CinderLib in RHVH (as in RHEL) in order to complete the test.

Comment 3 Michal Skrivanek 2020-07-17 04:26:08 UTC
It doesn’t block anything. It only makes automation a little bit different because you have to reconfigure it later. 
We can defer it u til we decide to enable cinderlib by default

Comment 4 Sandro Bonazzola 2020-07-30 07:46:56 UTC
Didi this looks like a backup / restore issue, can you please have a look?

Comment 5 Yedidyah Bar David 2020-07-30 08:38:18 UTC
(In reply to Shir Fishbain from comment #0)
> Description of problem:
> As a part of the plan to run the CinderLib integration flow for backup and
> restore from 4.3 to 4.4 with RHVH hosts, find that we have never installed
> CinderLib as part of the hosted engine deploy. 
> We can see it also in github :
> https://github.com/oVirt/ovirt-ansible-hosted-engine-setup there is nothing
> about CinderLib there.

Can you please clarify what the problem is, exactly? Thanks.

> 
> Version-Release number of selected component (if applicable):
> ovirt-engine-4.3.11.2-0.1.el7.noarch
> 
> How reproducible:
> 100%
> 
> Steps to Reproduce:
> 1. Running manually the "engine-setup --reconfigure-optional-components" on 
> hosted engine environment with RHVH hosts.

In which version? Before upgrade? After upgrade?

> 2. In the engine-setup : 
>           Set up Cinderlib integration
>           (Currently in tech preview)
>           (Yes, No) [No]: yes
> 
> Actual results:
> [ INFO  ] Checking for product updates...
> [ INFO  ] No product updates found

Ok, but what's next? Is the above line in itself a problem? Did engine-setup fail? Please clarify.

Also: Please note that engine-setup (or the relevant packages' dependencies/requirements) specifically do not handle _installing_ cinderlib. You have to do this yourself. But I do not think this should affect engine-setup - it should still create db/user etc. if you reply Yes.

> There is nothing about CinderLib in ovirt-ansible-hosted-engine-setup .

If you mean "in its code", you are right, but I am not sure why this is a problem.
If you search, you'll also not find there any mention of e.g. websocket-proxy, but it's still working.

> The "ovirt_cinderlib ovirt_cinderlib" lines are missing in PostgreSQL Client
> Authentication Configuration File. (less /var/lib/pgsql/data/pg_hba.conf)

You mean, after you run above engine-setup? Sounds like a bug. Please attach setup log. Thanks!

> 
> Expected results:
> Get the support in ovirt-ansible-hosted-engine-setup for completed
> successfully the rest of the CinderLib integration flow for backup and
> restore from 4.3 to 4.4 with RHVH hosts.

You mean, that you want support in the software for doing:
1. Install 4.3 hosted-engine without cinderlib
2. Upgrade to 4.4 in a single "step", and have cinderlib
?

As Michal noted, I do not think we'll do this before it's out of "Tech Preview", but this is mainly a question for PM - it's an RFE, anyway, not a bug.

Without fixing this, all you really want is reasonable procedures to:

1. Install and setup with cinderlib in 4.3, upgrade to 4.4 and keep cinderlib working
2. Install 4.3 without cinderlib, upgrade to 4.4, add cinderlib

Am I missing something? Is any of these problematic?

Thanks!

Comment 7 Shir Fishbain 2020-08-30 22:51:52 UTC
Created attachment 1713091 [details]
setup.log

Comment 8 Yedidyah Bar David 2020-10-21 09:30:55 UTC
(In reply to Shir Fishbain from comment #7)
> Created attachment 1713091 [details]
> setup.log

Above has:

2020-08-31 01:30:56,629+0300 ERROR otopi.plugins.ovirt_engine_common.ovirt_engine.system.he he._validate:114 It seems that you are running your engine inside of the hosted-engine VM and are not in "Global Maintenance" mode.
In that case you should put the system into the "Global Maintenance" mode before running engine-setup, or the hosted-engine HA agent might kill the machine, which might corrupt your data.

Did you set global maintenance mode?

Comment 13 Shir Fishbain 2021-01-06 10:23:36 UTC
Verified 

After set to global maintenance mode, it looks better, the Setup Cinderlib integration is True and the Configure local CinderLib database is True too.

The engine-setup --reconfigure-optional-components" command still failed although the configuration of CinderLib database to true
Moreover, the CinderLib integration flow completed successfully but it still impossible to add a new MBD via REST API and failed on CinderLib DB required.
I have opened a bug on this issue: https://bugzilla.redhat.com/show_bug.cgi?id=1913224

Comment 14 Sandro Bonazzola 2021-01-12 16:23:52 UTC
This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.