Bug 185776

Summary: Review Request: gitweb
Product: [Fedora] Fedora Reporter: bkyoung <bkyoung>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: pertusus
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-06 15:36:08 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 201449    
Attachments:
Description Flags
Spec for for gitweb.
none
Object location adjustments.
none
A quick installation test/check; Additional info.
none
Spec for gitweb. Fixed #5.
none
Spec file - Changed directory to gitweb.
none
Object location adjustments.
none
A quick installation test/check. Additional info. none

Description bkyoung 2006-03-17 16:16:55 EST
Spec Name or Url: Attached
SRPM Name or Url: Build separately
Description: A CGI based web interface for git projects published to a git repository.

See notes at end of attached gitweb-check for obtaining source tarball.

Attached:
gitweb.spec
gitweb-2.6.4-gitweb.cgi.patch
gitweb-check

BEGIN OUTPUT rpmlint
W: gitweb dangerous-command-in-%post chown
W: gitweb dangerous-command-in-%postun groupdel
END OUTPUT rpmlint
Comment 1 bkyoung 2006-03-17 16:18:17 EST
Created attachment 126287 [details]
Spec for for gitweb.
Comment 2 bkyoung 2006-03-17 16:19:08 EST
Created attachment 126288 [details]
Object location adjustments.
Comment 3 bkyoung 2006-03-17 16:19:51 EST
Created attachment 126289 [details]
A quick installation test/check; Additional info.
Comment 4 bkyoung 2006-03-17 19:15:48 EST
Comment on attachment 126287 [details]
Spec for for gitweb.

>%postun
># Remove group %{_gitweb_group}
>groupdel %{_gitweb_group}
>

%postun
if test $1 -eq 0; then
# Remove group %{_gitweb_group} for erase
	groupdel %{_gitweb_group} || true > /dev/null 2>&1
fi

The _gitweb_group should remain after an upgrade, but be removed after an
erase!
Comment 5 Paul Howarth 2006-03-18 04:22:22 EST
(In reply to comment #4)
> (From update of attachment 126287 [details] [edit])
> >%postun
> ># Remove group %{_gitweb_group}
> >groupdel %{_gitweb_group}
> >
> 
> %postun
> if test $1 -eq 0; then
> # Remove group %{_gitweb_group} for erase
> 	groupdel %{_gitweb_group} || true > /dev/null 2>&1
> fi
> 
> The _gitweb_group should remain after an upgrade, but be removed after an
> erase!

It should only be removed if you can be sure that no files belonging to this
group will remain on the system after the package has been removed. Otherwise,
the group should not be removed at all.
Comment 6 bkyoung 2006-03-18 12:56:45 EST
Created attachment 126309 [details]
Spec for gitweb. Fixed #5.
Comment 7 bkyoung 2006-03-21 22:02:13 EST
Created attachment 126451 [details]
Spec file - Changed directory to gitweb.
Comment 8 bkyoung 2006-03-21 22:02:59 EST
Created attachment 126452 [details]
Object location adjustments.
Comment 9 bkyoung 2006-03-21 22:04:02 EST
Created attachment 126453 [details]
A quick installation test/check. Additional info.
Comment 10 Patrice Dumas 2006-07-23 17:26:37 EDT
Could you please add the url to the spec file and the srpm in a 
bugzilla comment?
Comment 11 Jason Tibbitts 2006-08-30 02:12:20 EDT
I will close this bug in one week if there is no response.