Bug 1857893

Summary:	assertj-core fails to build with java-11-openjdk
Product:	[Fedora] Fedora	Reporter:	jiri vanek <jvanek>
Component:	assertj-core	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, java-maint-sig, jvanek, markku.korkeala, roman, sgehwolf, stewardship-sig
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	assertj-core-3.16.1-4.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-21 16:20:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1825969

Description jiri vanek 2020-07-16 17:52:45 UTC

assertj-core fails to build with java-11-openjdk as sytem JDK. See https://fedoraproject.org/wiki/Changes/Java11 .
See especially part about known failures: https://fedoraproject.org/wiki/Changes/Java11#common_issues_packagers_can_face_and_gathered_solutions

For the build logs, see: https://koji.fedoraproject.org/koji/taskinfo?taskID=47147408
We run the rebuild longer then 10days ago. Log may be gone. Also your package may be passing in regular rawhide.
To reproduce, simply: fedpkg clone assertj-core; cd assertj-core;  fedpkg build --target f33-java11; #The target is crucial.

We run two reruns your package failed both.


We had tried 650 packages, and 500 had passed, so the java-11-openjdk will be system JDK in f33, and you should fix your package if you want to keep it alive. Usually the fix is simple, and best is to update the package to latest upstream version.
There will be usual mass rebuild once f33 branches. You may got another FTBFS bug.
Let us know here if you have any questions, here in bug, or at java-devel.org .

We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side if needed.

Comment 1 jiri vanek 2020-07-17 03:39:48 UTC

highlight: This was rebuild in sidetag f33-java11. Thus --target is really necessary to reproduce failure.
please note: This side tag, f33-java11, will be merged to main f33 buildroot in aprox 14 days.

Comment 2 Fabio Valentini 2020-07-18 18:30:08 UTC

The build failure seems to be caused by some Java 9 Modules related issue:

[INFO] --- maven-compiler-plugin:3.8.1:compile (jdk9) @ assertj-core ---
[WARNING] Can't extract module name from hamcrest.jar: null
[WARNING] Can't extract module name from byte-buddy-dep.jar: null
[WARNING] Can't extract module name from classes: null
[WARNING] Can't extract module name from byte-buddy.jar: null
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to /builddir/build/BUILD/assertj-core-assertj-core-3.16.1/target/classes/META-INF/versions/9
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /builddir/build/BUILD/assertj-core-assertj-core-3.16.1/src/main/java9/module-info.java:[43,22] module not found: net.bytebuddy
[ERROR] /builddir/build/BUILD/assertj-core-assertj-core-3.16.1/src/main/java9/module-info.java:[44,22] module not found: org.hamcrest
[INFO] 2 errors 

Can we just disable the jdk9 configuration in maven-compiler-plugin?

Comment 3 Markku Korkeala 2020-07-21 14:38:27 UTC

I think we can remove the whole profiles-section from pom.xml, it builds without it. I've sent a PR:
https://src.fedoraproject.org/rpms/assertj-core/pull-request/5

Comment 4 Fabio Valentini 2020-07-21 16:20:53 UTC

Thanks! Merged and built:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1544581