Bug 1858020

Summary:	junit fails to build with java-11-openjdk
Product:	[Fedora] Fedora	Reporter:	jiri vanek <jvanek>
Component:	junit	Assignee:	Java Package Maintainers <java-maint-sig>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dbhole, decathorpe, java-maint-sig, java-sig-commits, jvanek, krzysztof.daniel, mizdebsk, sgehwolf, sochotni, stewardship-sig
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	junit-4.12-18.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-08-08 12:23:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1825969

Description jiri vanek 2020-07-16 20:36:40 UTC

junit fails to build with java-11-openjdk as sytem JDK. See https://fedoraproject.org/wiki/Changes/Java11 .
See especially part about known failures: https://fedoraproject.org/wiki/Changes/Java11#common_issues_packagers_can_face_and_gathered_solutions

For the build logs, see: https://koji.fedoraproject.org/koji/taskinfo?taskID=47156487
We run the rebuild longer then 10days ago. Log may be gone. Also your package may be passing in regular rawhide.
To reproduce, simply: fedpkg clone junit; cd junit;  fedpkg build --target f33-java11; #The target is crucial.

We run two reruns your package failed both.


We had tried 650 packages, and 500 had passed, so the java-11-openjdk will be system JDK in f33, and you should fix your package if you want to keep it alive. Usually the fix is simple, and best is to update the package to latest upstream version.
There will be usual mass rebuild once f33 branches. You may got another FTBFS bug.
Let us know here if you have any questions, here in bug, or at java-devel.org .

We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side if needed.

Comment 1 jiri vanek 2020-07-17 03:56:14 UTC

highlight: This was rebuild in sidetag f33-java11. Thus --target is really necessary to reproduce failure.
please note: This side tag, f33-java11, will be merged to main f33 buildroot in aprox 14 days.

Comment 2 Fabio Valentini 2020-07-17 08:42:19 UTC

The update to junit 4.13 would fix the Java 11 compilation issue, but it breaks jmock and mockito.
See: https://src.fedoraproject.org/rpms/junit/pull-request/1#comment-36339

Comment 3 Severin Gehwolf 2020-07-17 09:14:01 UTC

(In reply to Fabio Valentini from comment #2)
> The update to junit 4.13 would fix the Java 11 compilation issue, but it
> breaks jmock and mockito.
> See: https://src.fedoraproject.org/rpms/junit/pull-request/1#comment-36339

FWIW, my opinion is that this would have to be dealt with in jmock and mockito. We cannot sacrifice not moving forward for not breaking anything. It would be too much of a toll for individual packagers. I'm pretty sure Fedora will be better for it if junit moves forward and jmock and mockito gets fixed/dropped. This might seem a too harsh a stance to some, but it's one way to make forward progress.

Comment 4 Fabio Valentini 2020-07-17 09:31:09 UTC

Just .... no.

I won't just knowingly submit an update that will break other people's packages.

Comment 5 Fedora Admin user for bugzilla script actions 2020-07-29 02:49:43 UTC

This package has changed maintainer in the Fedora.
Reassigning to the new maintainer of this component.

Comment 6 Fabio Valentini 2020-08-08 12:23:16 UTC

Fixed by mbooth:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1583126